Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Side by Side Diff: base/callback_internal.cc

Issue 1129353003: Devirtualize base::BindState to save ~1% of Chrome's binary size (~1MB) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20150507-SizesExplorations
Patch Set: Keep the DCHECK Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/callback_internal.h ('k') | base/callback_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/callback_internal.h" 5 #include "base/callback_internal.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 8
9 namespace base { 9 namespace base {
10 namespace internal { 10 namespace internal {
11 11
12 void BindStateBase::AddRef() {
13 AtomicRefCountInc(&ref_count_);
14 }
15
16 void BindStateBase::Release() {
17 if (!AtomicRefCountDec(&ref_count_))
18 destructor_(this);
19 }
20
12 CallbackBase::CallbackBase(const CallbackBase& c) = default; 21 CallbackBase::CallbackBase(const CallbackBase& c) = default;
13 CallbackBase& CallbackBase::operator=(const CallbackBase& c) = default; 22 CallbackBase& CallbackBase::operator=(const CallbackBase& c) = default;
14 23
15 void CallbackBase::Reset() { 24 void CallbackBase::Reset() {
16 polymorphic_invoke_ = NULL; 25 polymorphic_invoke_ = NULL;
17 // NULL the bind_state_ last, since it may be holding the last ref to whatever 26 // NULL the bind_state_ last, since it may be holding the last ref to whatever
18 // object owns us, and we may be deleted after that. 27 // object owns us, and we may be deleted after that.
19 bind_state_ = NULL; 28 bind_state_ = NULL;
20 } 29 }
21 30
22 bool CallbackBase::Equals(const CallbackBase& other) const { 31 bool CallbackBase::Equals(const CallbackBase& other) const {
23 return bind_state_.get() == other.bind_state_.get() && 32 return bind_state_.get() == other.bind_state_.get() &&
24 polymorphic_invoke_ == other.polymorphic_invoke_; 33 polymorphic_invoke_ == other.polymorphic_invoke_;
25 } 34 }
26 35
27 CallbackBase::CallbackBase(BindStateBase* bind_state) 36 CallbackBase::CallbackBase(BindStateBase* bind_state)
28 : bind_state_(bind_state), 37 : bind_state_(bind_state),
29 polymorphic_invoke_(NULL) { 38 polymorphic_invoke_(NULL) {
30 DCHECK(!bind_state_.get() || bind_state_->HasOneRef()); 39 DCHECK(!bind_state_.get() || bind_state_->ref_count_ == 1);
31 } 40 }
32 41
33 CallbackBase::~CallbackBase() { 42 CallbackBase::~CallbackBase() {
34 } 43 }
35 44
36 } // namespace internal 45 } // namespace internal
37 } // namespace base 46 } // namespace base
OLDNEW
« no previous file with comments | « base/callback_internal.h ('k') | base/callback_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698