Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1129333005: Plumb input events into SkyView (Closed)

Created:
5 years, 7 months ago by abarth-chromium
Modified:
5 years, 7 months ago
Reviewers:
eseidel
CC:
gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Plumb input events into SkyView Clients can now register a callback that gets called whenever we have an event for the view. We'll need to update the Event class at some point, but this is a start. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9576d800af4be6b92311c5d3953fe3c98079f282

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -12 lines) Patch
M sky/engine/core/core.gni View 1 chunk +1 line, -0 lines 0 comments Download
A sky/engine/core/view/EventCallback.h View 1 chunk +19 lines, -0 lines 0 comments Download
A + sky/engine/core/view/EventCallback.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/view/View.h View 2 chunks +5 lines, -0 lines 0 comments Download
M sky/engine/core/view/View.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M sky/engine/core/view/View.idl View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/public/sky/sky_view.cc View 2 chunks +29 lines, -1 line 0 comments Download
M sky/examples/raw/hello_world.dart View 1 chunk +24 lines, -8 lines 0 comments Download
M sky/shell/ui/engine.cc View 1 chunk +3 lines, -1 line 1 comment Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
5 years, 7 months ago (2015-05-19 23:44:24 UTC) #1
eseidel
lgtm https://codereview.chromium.org/1129333005/diff/1/sky/shell/ui/engine.cc File sky/shell/ui/engine.cc (right): https://codereview.chromium.org/1129333005/diff/1/sky/shell/ui/engine.cc#newcode172 sky/shell/ui/engine.cc:172: if (true) { You don't want this.
5 years, 7 months ago (2015-05-19 23:49:00 UTC) #2
abarth-chromium
On 2015/05/19 at 23:49:00, eseidel wrote: > lgtm > > https://codereview.chromium.org/1129333005/diff/1/sky/shell/ui/engine.cc > File sky/shell/ui/engine.cc (right): ...
5 years, 7 months ago (2015-05-19 23:49:46 UTC) #3
abarth-chromium
5 years, 7 months ago (2015-05-19 23:50:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9576d800af4be6b92311c5d3953fe3c98079f282 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698