Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1129333004: Inline SVGTextLayoutAttributes::emptyValue (Closed)

Created:
5 years, 7 months ago by fs
Modified:
5 years, 7 months ago
Reviewers:
pdr., f(malita)
CC:
blink-reviews, blink-reviews-rendering, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Inline SVGTextLayoutAttributes::emptyValue This function just returns a simple float - inlining it allows the compiler to generate more efficient code (and smaller - ~.5k) code since the relatively high overhead call can be eliminated. Take the opportunity to change the "empty value" into NaN (instead of "max() - 1"), with corresponding semantic changes required by that. BUG=486669 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195555

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -19 lines) Patch
M Source/core/layout/svg/LayoutSVGInlineText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/SVGTextLayoutAttributes.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/layout/svg/SVGTextLayoutAttributes.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/svg/SVGTextLayoutEngine.cpp View 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
While walking home from the office, I got the feeling that I may have done ...
5 years, 7 months ago (2015-05-19 21:33:13 UTC) #2
pdr.
lgtm
5 years, 7 months ago (2015-05-19 21:50:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129333004/1
5 years, 7 months ago (2015-05-19 21:51:18 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 21:54:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195555

Powered by Google App Engine
This is Rietveld 408576698