openssl/ssl/s3_clnt.c - Issue 112933006: OpenSSL: add support for the TLS padding extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: openssl/ssl/s3_clnt.c

Issue 112933006: OpenSSL: add support for the TLS padding extension. Base URL: https://chromium.googlesource.com/chromium/deps/openssl.git@master

Patch Set: Add comments at ClientHello construction sites Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: openssl/ssl/s3_clnt.c

diff --git a/openssl/ssl/s3_clnt.c b/openssl/ssl/s3_clnt.c

index 85ffd6780bc0e23e1bb93205b7762112aa09bf27..e47eef1b62dda4cd6ccec1860a044d698befeae7 100644

--- a/openssl/ssl/s3_clnt.c

+++ b/openssl/ssl/s3_clnt.c

@@ -757,7 +757,9 @@ int ssl3_client_hello(SSL *s)

if (RAND_pseudo_bytes(p,SSL3_RANDOM_SIZE-4) <= 0)

goto err;

- /* Do the message type and length last */

+ /* Do the message type and length last.

+ * Note: the code to add the padding extension in t1_lib.c

+ * depends on the size of this prefix. */

d=p= &(buf[4]);

/* version indicates the negotiated version: for example from

« no previous file with comments | « openssl/ssl/s23_clnt.c ('k') | openssl/ssl/t1_lib.c » ('j') | no next file with comments »