Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/typing.h

Issue 112933002: Fix off-by-one error in AstTyper, part 2. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-param-local-type.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 e->set_bounds(Bounds::NarrowLower(e->bounds(), t, isolate_)); 76 e->set_bounds(Bounds::NarrowLower(e->bounds(), t, isolate_));
77 } 77 }
78 78
79 Effects EnterEffects() { 79 Effects EnterEffects() {
80 store_ = store_.Push(); 80 store_ = store_.Push();
81 return store_.Top(); 81 return store_.Top();
82 } 82 }
83 void ExitEffects() { store_ = store_.Pop(); } 83 void ExitEffects() { store_ = store_.Pop(); }
84 84
85 int variable_index(Variable* var) { 85 int variable_index(Variable* var) {
86 // Stack locals have the range [0 .. l]
87 // Parameters have the range [-1 .. p]
88 // We map this to [-p-2 .. -1, 0 .. l]
86 return var->IsStackLocal() ? var->index() : 89 return var->IsStackLocal() ? var->index() :
87 var->IsParameter() ? -var->index() - 1 : kNoVar; 90 var->IsParameter() ? -var->index() - 2 : kNoVar;
88 } 91 }
89 92
90 void VisitDeclarations(ZoneList<Declaration*>* declarations); 93 void VisitDeclarations(ZoneList<Declaration*>* declarations);
91 void VisitStatements(ZoneList<Statement*>* statements); 94 void VisitStatements(ZoneList<Statement*>* statements);
92 95
93 #define DECLARE_VISIT(type) virtual void Visit##type(type* node); 96 #define DECLARE_VISIT(type) virtual void Visit##type(type* node);
94 AST_NODE_LIST(DECLARE_VISIT) 97 AST_NODE_LIST(DECLARE_VISIT)
95 #undef DECLARE_VISIT 98 #undef DECLARE_VISIT
96 99
97 DISALLOW_COPY_AND_ASSIGN(AstTyper); 100 DISALLOW_COPY_AND_ASSIGN(AstTyper);
98 }; 101 };
99 102
100 } } // namespace v8::internal 103 } } // namespace v8::internal
101 104
102 #endif // V8_TYPING_H_ 105 #endif // V8_TYPING_H_
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-param-local-type.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698