Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 11293291: Revert 167793 - Moving prepopulated search engines to a JSON file. (Closed)

Created:
8 years, 1 month ago by danakj
Modified:
8 years, 1 month ago
Reviewers:
beaudoin
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Revert 167793 - Moving prepopulated search engines to a JSON file. This CL also includes the python script required to convert the JSON file to a .cc/.h pair. The generated .cc/.h are not generated by the build process and must be committed to the repository. BUG=159990 Review URL: https://chromiumcodereview.appspot.com/11377049 TBR=beaudoin@chromium.org Compiler errors: http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Builder&number=28409 http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20Builder%20%28dbg%29&number=4778 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167796

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2429 lines, -2505 lines) Patch
D build/json_to_struct.gypi View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/search_engines/prepopulated_engines.gyp View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/search_engines/prepopulated_engines.json View 1 chunk +0 lines, -1724 lines 0 comments Download
D chrome/browser/search_engines/prepopulated_engines_schema.json View 1 chunk +0 lines, -63 lines 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data.cc View 6 chunks +2429 lines, -9 lines 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc View 3 chunks +0 lines, -37 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D tools/json_to_struct/PRESUBMIT.py View 1 chunk +0 lines, -20 lines 0 comments Download
D tools/json_to_struct/element_generator.py View 1 chunk +0 lines, -121 lines 0 comments Download
D tools/json_to_struct/element_generator_test.py View 1 chunk +0 lines, -158 lines 0 comments Download
D tools/json_to_struct/json_to_struct.py View 1 chunk +0 lines, -199 lines 0 comments Download
D tools/json_to_struct/struct_generator.py View 1 chunk +0 lines, -43 lines 0 comments Download
D tools/json_to_struct/struct_generator_test.py View 1 chunk +0 lines, -58 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
danakj
8 years, 1 month ago (2012-11-15 00:54:30 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698