Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 11293258: Merge 134377 - Crash when replacing parts of text inputs with content: url(...) (Closed)

Created:
8 years, 1 month ago by karen
Modified:
8 years, 1 month ago
Reviewers:
tasak
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 134377 - Crash when replacing parts of text inputs with content: url(...) https://bugs.webkit.org/show_bug.cgi?id=101133 Reviewed by Kent Tamura. Source/WebCore: Disable directly setting content of elements in an input element's shadow dom tree, because the setting breaks input element's behavior. Tests: fast/forms/number/number-content-url-crash.html fast/forms/search/search-content-url-crash.html * css/html.css: (input::-webkit-textfield-decoration-container): Use important to disable overriding an input element's content property. * html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::attach): Added ASSERTION. No content should be applied to input::-webkit-textfield-decoration-container. LayoutTests: * fast/forms/number/number-content-url-crash-expected.txt: Added. * fast/forms/number/number-content-url-crash.html: Added. * fast/forms/search/search-content-url-crash-expected.txt: Added. * fast/forms/search/search-content-url-crash.html: Added. TBR=tasak@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134459

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, --4 lines) Patch
A + LayoutTests/fast/forms/number/number-content-url-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/number/number-content-url-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/search/search-content-url-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/search/search-content-url-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/css/html.css View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/html/TextFieldInputType.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
karen
8 years, 1 month ago (2012-11-13 19:40:53 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698