Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2186)

Unified Diff: net/url_request/url_request_filter_unittest.cc

Issue 11293252: Change Interceptors into URLRequestJobFactory::ProtocolHandlers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address erikwright's third round of comments Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_filter_unittest.cc
diff --git a/net/url_request/url_request_filter_unittest.cc b/net/url_request/url_request_filter_unittest.cc
index 9f116756acddafd81ef28abc5fed13e3d9f9235a..eddeca7a1f3b2dddb982e958014ba7de7452e45a 100644
--- a/net/url_request/url_request_filter_unittest.cc
+++ b/net/url_request/url_request_filter_unittest.cc
@@ -67,23 +67,11 @@ TEST(URLRequestFilter, BasicMatching) {
&request_2, request_context.network_delegate(), url_2.scheme()) == NULL);
EXPECT_EQ(1, URLRequestFilter::GetInstance()->hit_count());
- // Check we can overwrite URL handler.
- EXPECT_TRUE(URLRequestFilter::GetInstance()->AddUrlHandler(url_1,
- &FactoryB));
- {
- scoped_refptr<URLRequestJob> found = URLRequestFilter::Factory(
- &request_1, request_context.network_delegate(), url_1.scheme());
- EXPECT_EQ(job_b, found);
- EXPECT_TRUE(job_b != NULL);
- job_b = NULL;
- }
- EXPECT_EQ(2, URLRequestFilter::GetInstance()->hit_count());
-
// Check we can remove URL matching.
URLRequestFilter::GetInstance()->RemoveUrlHandler(url_1);
EXPECT_TRUE(URLRequestFilter::Factory(
&request_1, request_context.network_delegate(), url_1.scheme()) == NULL);
- EXPECT_EQ(URLRequestFilter::GetInstance()->hit_count(), 2);
+ EXPECT_EQ(1, URLRequestFilter::GetInstance()->hit_count());
// Check hostname matching.
URLRequestFilter::GetInstance()->ClearHandlers();
@@ -103,27 +91,14 @@ TEST(URLRequestFilter, BasicMatching) {
// Check we don't match other hostnames.
EXPECT_TRUE(URLRequestFilter::Factory(
&request_2, request_context.network_delegate(), url_2.scheme()) == NULL);
- EXPECT_EQ(URLRequestFilter::GetInstance()->hit_count(), 1);
-
- // Check we can overwrite hostname handler.
- URLRequestFilter::GetInstance()->AddHostnameHandler(url_1.scheme(),
- url_1.host(),
- &FactoryA);
- {
- scoped_refptr<URLRequestJob> found = URLRequestFilter::Factory(
- &request_1, request_context.network_delegate(), url_1.scheme());
- EXPECT_EQ(job_a, found);
- EXPECT_TRUE(job_a != NULL);
- job_a = NULL;
- }
- EXPECT_EQ(2, URLRequestFilter::GetInstance()->hit_count());
+ EXPECT_EQ(1, URLRequestFilter::GetInstance()->hit_count());
// Check we can remove hostname matching.
URLRequestFilter::GetInstance()->RemoveHostnameHandler(url_1.scheme(),
url_1.host());
EXPECT_TRUE(URLRequestFilter::Factory(
&request_1, request_context.network_delegate(), url_1.scheme()) == NULL);
- EXPECT_EQ(2, URLRequestFilter::GetInstance()->hit_count());
+ EXPECT_EQ(1, URLRequestFilter::GetInstance()->hit_count());
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698