Change Interceptors into URLRequestJobFactory::ProtocolHandlers.

content/test/net/url_request_abort_on_end_job.cc

Index: content/test/net/url_request_abort_on_end_job.cc
diff --git a/content/test/net/url_request_abort_on_end_job.cc b/content/test/net/url_request_abort_on_end_job.cc
index 67d10a4a24688eaa065f59e65e611ae4c11d3407..2c075bf4975d4c6e2f7bc033f413610bb2a5954e 100644
--- a/content/test/net/url_request_abort_on_end_job.cc
+++ b/content/test/net/url_request_abort_on_end_job.cc
@@ -27,6 +27,13 @@ const char URLRequestAbortOnEndJob::k400AbortOnEndUrl[] =
 
 // static
 void URLRequestAbortOnEndJob::AddUrlHandler() {
+  BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
+                          base::Bind(AddUrlHandlerOnIOThread));
+}
+
+// static
+void URLRequestAbortOnEndJob::AddUrlHandlerOnIOThread() {

[erikwright (departed), 2012/12/06 15:26:28]

This could be a free function in anonymous namespace to avoid polluting the
class declaration.

Unless it also makes sense to make Factory a private function, in which case
this would need to stay a member.

Ultimately, I would make this and Factory free functions in anon namespace and
make the constructor public, assuming that with this change there are no
remaining direct uses of the Factory.

[pauljensen, 2012/12/07 18:47:42]

Done.

+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   net::URLRequestFilter* filter = net::URLRequestFilter::GetInstance();
   filter->AddUrlHandler(GURL(k400AbortOnEndUrl),
                         &URLRequestAbortOnEndJob::Factory);