Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1283)

Unified Diff: chrome/browser/net/connect_interceptor.cc

Issue 11293252: Change Interceptors into URLRequestJobFactory::ProtocolHandlers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: some cleanup Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/connect_interceptor.cc
diff --git a/chrome/browser/net/connect_interceptor.cc b/chrome/browser/net/connect_interceptor.cc
index c1d6deac19b66137cd1179dc5153e8147e91c9de..09aa284c31b71c1b568d0922072be4c49221df0c 100644
--- a/chrome/browser/net/connect_interceptor.cc
+++ b/chrome/browser/net/connect_interceptor.cc
@@ -6,6 +6,7 @@
#include "chrome/browser/net/predictor.h"
#include "net/base/load_flags.h"
+#include "net/url_request/protocol_intercept_job_factory.h"
#include "net/url_request/url_request.h"
namespace chrome_browser_net {
@@ -17,6 +18,17 @@ namespace chrome_browser_net {
// TODO(jar): We should do a persistent field trial to validate/optimize this.
static const int kMaxUnusedSocketLifetimeSecondsWithoutAGet = 10;
+// static
+scoped_ptr<net::URLRequestJobFactory>
+ConnectInterceptor::CreateURLRequestJobFactory(
+ scoped_ptr<net::URLRequestJobFactory> base_job_factory,
+ Predictor* predictor) {
+ scoped_ptr<net::URLRequestJobFactory> top_job_factory(
+ new net::ProtocolInterceptJobFactory(base_job_factory.Pass(), NULL,
+ new ConnectInterceptor(predictor)));
+ return top_job_factory.Pass();
+}
+
ConnectInterceptor::ConnectInterceptor(Predictor* predictor)
: timed_cache_(base::TimeDelta::FromSeconds(
kMaxUnusedSocketLifetimeSecondsWithoutAGet)),
@@ -27,7 +39,7 @@ ConnectInterceptor::ConnectInterceptor(Predictor* predictor)
ConnectInterceptor::~ConnectInterceptor() {
}
-net::URLRequestJob* ConnectInterceptor::MaybeIntercept(
+net::URLRequestJob* ConnectInterceptor::MaybeCreateJob(
net::URLRequest* request, net::NetworkDelegate* network_delegate) const {
GURL request_scheme_host(Predictor::CanonicalizeUrl(request->url()));
if (request_scheme_host == GURL::EmptyGURL())
@@ -87,18 +99,6 @@ net::URLRequestJob* ConnectInterceptor::MaybeIntercept(
return NULL;
}
-net::URLRequestJob* ConnectInterceptor::MaybeInterceptResponse(
- net::URLRequest* request, net::NetworkDelegate* network_delegate) const {
- return NULL;
-}
-
-net::URLRequestJob* ConnectInterceptor::MaybeInterceptRedirect(
- const GURL& location,
- net::URLRequest* request,
- net::NetworkDelegate* network_delegate) const {
- return NULL;
-}
-
ConnectInterceptor::TimedCache::TimedCache(const base::TimeDelta& max_duration)
: mru_cache_(UrlMruTimedCache::NO_AUTO_EVICT),
max_duration_(max_duration) {

Powered by Google App Engine
This is Rietveld 408576698