Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2800)

Unified Diff: android_webview/native/android_protocol_handler.cc

Issue 11293252: Change Interceptors into URLRequestJobFactory::ProtocolHandlers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/native/android_protocol_handler.h ('k') | android_webview/native/cookie_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/native/android_protocol_handler.cc
diff --git a/android_webview/native/android_protocol_handler.cc b/android_webview/native/android_protocol_handler.cc
index a5da6fdde488d95f732e1249f65c3f8e53d0e1d0..907881bae85822301eb9d1d435e0c8d1e23f7443 100644
--- a/android_webview/native/android_protocol_handler.cc
+++ b/android_webview/native/android_protocol_handler.cc
@@ -20,6 +20,7 @@
#include "net/base/net_errors.h"
#include "net/base/net_util.h"
#include "net/http/http_util.h"
+#include "net/url_request/protocol_intercept_job_factory.h"
#include "net/url_request/url_request.h"
using android_webview::InputStream;
@@ -66,22 +67,18 @@ class AndroidStreamReaderURLRequestJobDelegateImpl
};
class AssetFileProtocolInterceptor :
- public net::URLRequestJobFactory::Interceptor {
+ public net::URLRequestJobFactory::ProtocolHandler {
public:
- AssetFileProtocolInterceptor();
virtual ~AssetFileProtocolInterceptor() OVERRIDE;
- virtual net::URLRequestJob* MaybeIntercept(
- net::URLRequest* request,
- net::NetworkDelegate* network_delegate) const OVERRIDE;
- virtual net::URLRequestJob* MaybeInterceptRedirect(
- const GURL& location,
- net::URLRequest* request,
- net::NetworkDelegate* network_delegate) const OVERRIDE;
- virtual net::URLRequestJob* MaybeInterceptResponse(
+ static scoped_ptr<net::URLRequestJobFactory> CreateURLRequestJobFactory(
+ scoped_ptr<net::URLRequestJobFactory> base_job_factory);
+ virtual net::URLRequestJob* MaybeCreateJob(
net::URLRequest* request,
net::NetworkDelegate* network_delegate) const OVERRIDE;
private:
+ AssetFileProtocolInterceptor();
+
// file:///android_asset/
const std::string asset_prefix_;
// file:///android_res/
@@ -196,7 +193,19 @@ AssetFileProtocolInterceptor::AssetFileProtocolInterceptor()
AssetFileProtocolInterceptor::~AssetFileProtocolInterceptor() {
}
-net::URLRequestJob* AssetFileProtocolInterceptor::MaybeIntercept(
+// static
+scoped_ptr<net::URLRequestJobFactory>
+AssetFileProtocolInterceptor::CreateURLRequestJobFactory(
+ scoped_ptr<net::URLRequestJobFactory> base_job_factory) {
+ scoped_ptr<net::URLRequestJobFactory> top_job_factory(
+ new net::ProtocolInterceptJobFactory(
+ base_job_factory.Pass(),
+ scoped_ptr<net::URLRequestJobFactory::ProtocolHandler>(
+ new AssetFileProtocolInterceptor())));
+ return top_job_factory.Pass();
+}
+
+net::URLRequestJob* AssetFileProtocolInterceptor::MaybeCreateJob(
net::URLRequest* request, net::NetworkDelegate* network_delegate) const {
if (!request->url().SchemeIsFile()) return NULL;
@@ -213,19 +222,6 @@ net::URLRequestJob* AssetFileProtocolInterceptor::MaybeIntercept(
new AndroidStreamReaderURLRequestJobDelegateImpl()));
}
-net::URLRequestJob* AssetFileProtocolInterceptor::MaybeInterceptRedirect(
- const GURL& location,
- net::URLRequest* request,
- net::NetworkDelegate* network_delegate) const {
- return NULL;
-}
-
-net::URLRequestJob* AssetFileProtocolInterceptor::MaybeInterceptResponse(
- net::URLRequest* request,
- net::NetworkDelegate* network_delegate) const {
- return NULL;
-}
-
} // namespace
namespace android_webview {
@@ -235,18 +231,18 @@ bool RegisterAndroidProtocolHandler(JNIEnv* env) {
}
// static
-void RegisterAndroidProtocolsOnIOThread(
- net::URLRequestContext* context,
- AwURLRequestJobFactory* job_factory) {
+scoped_ptr<net::URLRequestJobFactory> CreateAndroidRequestJobFactory(
+ scoped_ptr<AwURLRequestJobFactory> job_factory) {
// Register content://. Note that even though a scheme is
// registered here, it cannot be used by child processes until access to it is
// granted via ChildProcessSecurityPolicy::GrantScheme(). This is done in
// AwContentBrowserClient.
// The job factory takes ownership of the handler.
- job_factory->SetProtocolHandler(android_webview::kContentScheme,
- new ContentSchemeProtocolHandler());
- // The job factory takes ownership of the interceptor.
- job_factory->AddInterceptor(new AssetFileProtocolInterceptor());
+ bool set_protocol = job_factory->SetProtocolHandler(
+ android_webview::kContentScheme, new ContentSchemeProtocolHandler());
+ DCHECK(set_protocol);
+ return AssetFileProtocolInterceptor::CreateURLRequestJobFactory(
+ job_factory.PassAs<net::URLRequestJobFactory>());
}
// Set a context object to be used for resolving resource queries. This can
« no previous file with comments | « android_webview/native/android_protocol_handler.h ('k') | android_webview/native/cookie_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698