android_webview/native/net_init_native_callback.cc - Issue 11293252: Change Interceptors into URLRequestJobFactory::ProtocolHandlers.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: android_webview/native/net_init_native_callback.cc

Issue 11293252: Change Interceptors into URLRequestJobFactory::ProtocolHandlers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address erikwright's third round of comments Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« android_webview/native/cookie_manager.h ('K') | « android_webview/native/cookie_manager.cc ('k') | chrome/browser/component_updater/component_updater_interceptor.h » ('j') | chrome/browser/component_updater/component_updater_interceptor.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "android_webview/browser/net/init_native_callback.h"	5 #include "android_webview/browser/net/init_native_callback.h"

6	6

7 #include "android_webview/native/android_protocol_handler.h"	7 #include "android_webview/native/android_protocol_handler.h"

8 #include "android_webview/native/cookie_manager.h"	8 #include "android_webview/native/cookie_manager.h"

	9 #include "net/url_request/url_request_job_factory.h"

9	10

10 namespace android_webview {	11 namespace android_webview {

11	12

12 void OnNetworkStackInitialized(net::URLRequestContext* context,	13 scoped_ptr<net::URLRequestJobFactory> OnNetworkStackInitialized(
	mmenke 2012/12/11 17:22:38 I think having an "OnBlah" function return a value I think having an "OnBlah" function return a value is pretty confusing and unexpected. It's not at all clear from the name just what it's actually returning. Maybe CreateAndroidJobFactoryAndInitializeContext? I'm open to better ideas.
13 net::URLRequestJobFactory* job_factory) {	14 net::URLRequestContext* context,

14 RegisterAndroidProtocolsOnIOThread(context, job_factory);	15 scoped_ptr<net::URLRequestJobFactory> job_factory) {

15 SetCookieMonsterOnNetworkStackInit(context, job_factory);	16 job_factory = RegisterAndroidProtocolsOnIOThread(context, job_factory.Pass());

	17 SetCookieMonsterOnNetworkStackInit(context);

	18 return job_factory.Pass();

16 }	19 }

17	20

18 }	21 }
	mmenke 2012/12/11 17:22:38 nit: While you're here, this should have a "// na nit: While you're here, this should have a "// namespace android_webview"
OLD	NEW