Change Interceptors into URLRequestJobFactory::ProtocolHandlers.

chrome/browser/extensions/api/management/management_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/memory/ref_counted.h"
 #include "base/stl_util.h"
 #include "chrome/browser/extensions/autoupdate_interceptor.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
@@ skipping 232 matching lines @@
 #else
 #define MAYBE_AutoUpdate AutoUpdate
 #endif
 #endif
 
 // Tests extension autoupdate.
 IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, MAYBE_AutoUpdate) {
   NotificationListener notification_listener;
   FilePath basedir = test_data_dir_.AppendASCII("autoupdate");
   // Note: This interceptor gets requests on the IO thread.
-  scoped_refptr<extensions::AutoUpdateInterceptor> interceptor(
-      new extensions::AutoUpdateInterceptor());
+  extensions::AutoUpdateInterceptor interceptor;
   net::URLFetcher::SetEnableInterceptionForTests(true);
 
-  interceptor->SetResponseOnIOThread("http://localhost/autoupdate/manifest",
-                                     basedir.AppendASCII("manifest_v2.xml"));
-  interceptor->SetResponseOnIOThread("http://localhost/autoupdate/v2.crx",
-                                     basedir.AppendASCII("v2.crx"));
+  interceptor.SetResponse("http://localhost/autoupdate/manifest",
+                          basedir.AppendASCII("manifest_v2.xml"));
+  interceptor.SetResponse("http://localhost/autoupdate/v2.crx",
+                          basedir.AppendASCII("v2.crx"));
 
   // Install version 1 of the extension.
   ExtensionTestMessageListener listener1("v1 installed", false);
   ExtensionService* service = extensions::ExtensionSystem::Get(
       browser()->profile())->extension_service();
   const size_t size_before = service->extensions()->size();
   ASSERT_TRUE(service->disabled_extensions()->is_empty());
   const Extension* extension =
       InstallExtension(basedir.AppendASCII("v1.crx"), 1);
   ASSERT_TRUE(extension);
@@ skipping 20 matching lines @@
   ASSERT_TRUE(extension);
   ASSERT_EQ("2.0", extension->VersionString());
   ASSERT_TRUE(notification_listener.started());
   ASSERT_TRUE(notification_listener.finished());
   ASSERT_TRUE(ContainsKey(notification_listener.updates(),
                           "ogjcoiohnmldgjemafoockdghcjciccf"));
   notification_listener.Reset();
 
   // Now try doing an update to version 3, which has been incorrectly
   // signed. This should fail.
-  interceptor->SetResponseOnIOThread("http://localhost/autoupdate/manifest",
-                                     basedir.AppendASCII("manifest_v3.xml"));
-  interceptor->SetResponseOnIOThread("http://localhost/autoupdate/v3.crx",
-                                     basedir.AppendASCII("v3.crx"));
+  interceptor.SetResponse("http://localhost/autoupdate/manifest",
+                          basedir.AppendASCII("manifest_v3.xml"));
+  interceptor.SetResponse("http://localhost/autoupdate/v3.crx",
+                          basedir.AppendASCII("v3.crx"));
 
   service->updater()->CheckNow(params);
   ASSERT_TRUE(WaitForExtensionInstallError());
   ASSERT_TRUE(notification_listener.started());
   ASSERT_TRUE(notification_listener.finished());
   ASSERT_TRUE(ContainsKey(notification_listener.updates(),
                           "ogjcoiohnmldgjemafoockdghcjciccf"));
 
   // Make sure the extension state is the same as before.
   ASSERT_EQ(size_before + 1, service->extensions()->size());
@@ skipping 13 matching lines @@
 #define MAYBE_AutoUpdateDisabledExtensions AutoUpdateDisabledExtensions
 #endif
 #endif
 
 // Tests extension autoupdate.
 IN_PROC_BROWSER_TEST_F(ExtensionManagementTest,
                        MAYBE_AutoUpdateDisabledExtensions) {
   NotificationListener notification_listener;
   FilePath basedir = test_data_dir_.AppendASCII("autoupdate");
   // Note: This interceptor gets requests on the IO thread.
-  scoped_refptr<extensions::AutoUpdateInterceptor> interceptor(
-      new extensions::AutoUpdateInterceptor());
+  extensions::AutoUpdateInterceptor interceptor;
   net::URLFetcher::SetEnableInterceptionForTests(true);
 
-  interceptor->SetResponseOnIOThread("http://localhost/autoupdate/manifest",
-                                     basedir.AppendASCII("manifest_v2.xml"));
-  interceptor->SetResponseOnIOThread("http://localhost/autoupdate/v2.crx",
-                                     basedir.AppendASCII("v2.crx"));
+  interceptor.SetResponse("http://localhost/autoupdate/manifest",
+                          basedir.AppendASCII("manifest_v2.xml"));
+  interceptor.SetResponse("http://localhost/autoupdate/v2.crx",
+                          basedir.AppendASCII("v2.crx"));
 
   // Install version 1 of the extension.
   ExtensionTestMessageListener listener1("v1 installed", false);
   ExtensionService* service = extensions::ExtensionSystem::Get(
       browser()->profile())->extension_service();
   const size_t enabled_size_before = service->extensions()->size();
   const size_t disabled_size_before = service->disabled_extensions()->size();
   const Extension* extension =
       InstallExtension(basedir.AppendASCII("v1.crx"), 1);
   ASSERT_TRUE(extension);
@@ skipping 41 matching lines @@
   ExtensionService* service = extensions::ExtensionSystem::Get(
       browser()->profile())->extension_service();
   const char* kExtensionId = "ogjcoiohnmldgjemafoockdghcjciccf";
   // We don't want autoupdate blacklist checks.
   extensions::ExtensionUpdater::CheckParams params;
   params.check_blacklist = false;
 
   FilePath basedir = test_data_dir_.AppendASCII("autoupdate");
 
   // Note: This interceptor gets requests on the IO thread.
-  scoped_refptr<extensions::AutoUpdateInterceptor> interceptor(
-      new extensions::AutoUpdateInterceptor());
+  extensions::AutoUpdateInterceptor interceptor;
   net::URLFetcher::SetEnableInterceptionForTests(true);
 
-  interceptor->SetResponseOnIOThread("http://localhost/autoupdate/manifest",
-                                     basedir.AppendASCII("manifest_v2.xml"));
-  interceptor->SetResponseOnIOThread("http://localhost/autoupdate/v2.crx",
-                                     basedir.AppendASCII("v2.crx"));
+  interceptor.SetResponse("http://localhost/autoupdate/manifest",
+                          basedir.AppendASCII("manifest_v2.xml"));
+  interceptor.SetResponse("http://localhost/autoupdate/v2.crx",
+                          basedir.AppendASCII("v2.crx"));
 
   const size_t size_before = service->extensions()->size();
   ASSERT_TRUE(service->disabled_extensions()->is_empty());
 
   extensions::PendingExtensionManager* pending_extension_manager =
       service->pending_extension_manager();
 
   // The code that reads external_extensions.json uses this method to inform
   // the ExtensionService of an extension to download.  Using the real code
   // is race-prone, because instantating the ExtensionService starts a read
@@ skipping 58 matching lines @@
   ExtensionService* service = extensions::ExtensionSystem::Get(
       browser()->profile())->extension_service();
   const char* kExtensionId = "ogjcoiohnmldgjemafoockdghcjciccf";
   // We don't want autoupdate blacklist checks.
   extensions::ExtensionUpdater::CheckParams params;
   params.check_blacklist = false;
 
   FilePath basedir = test_data_dir_.AppendASCII("autoupdate");
 
   // Note: This interceptor gets requests on the IO thread.
-  scoped_refptr<extensions::AutoUpdateInterceptor> interceptor(
-      new extensions::AutoUpdateInterceptor());
+  extensions::AutoUpdateInterceptor interceptor;
   net::URLFetcher::SetEnableInterceptionForTests(true);
 
-  interceptor->SetResponseOnIOThread("http://localhost/autoupdate/manifest",
-                                     basedir.AppendASCII("manifest_v2.xml"));
-  interceptor->SetResponseOnIOThread("http://localhost/autoupdate/v2.crx",
-                                     basedir.AppendASCII("v2.crx"));
+  interceptor.SetResponse("http://localhost/autoupdate/manifest",
+                          basedir.AppendASCII("manifest_v2.xml"));
+  interceptor.SetResponse("http://localhost/autoupdate/v2.crx",
+                          basedir.AppendASCII("v2.crx"));
 
   const size_t size_before = service->extensions()->size();
   ASSERT_TRUE(service->disabled_extensions()->is_empty());
 
   PrefService* prefs = browser()->profile()->GetPrefs();
   const ListValue* forcelist =
       prefs->GetList(prefs::kExtensionInstallForceList);
   ASSERT_TRUE(forcelist->empty()) << kForceInstallNotEmptyHelp;
 
   {
@@ skipping 51 matching lines @@
       browser()->profile())->extension_service();
   const char* kExtensionId = "ogjcoiohnmldgjemafoockdghcjciccf";
   extensions::ExtensionUpdater::CheckParams params;
   params.check_blacklist = false;
   service->updater()->set_default_check_params(params);
   const size_t size_before = service->extensions()->size();
   FilePath basedir = test_data_dir_.AppendASCII("autoupdate");
   ASSERT_TRUE(service->disabled_extensions()->is_empty());
 
   // Note: This interceptor gets requests on the IO thread.
-  scoped_refptr<extensions::AutoUpdateInterceptor> interceptor(
-      new extensions::AutoUpdateInterceptor());
+  extensions::AutoUpdateInterceptor interceptor;
   net::URLFetcher::SetEnableInterceptionForTests(true);
 
-  interceptor->SetResponseOnIOThread("http://localhost/autoupdate/manifest",
-                                     basedir.AppendASCII("manifest_v2.xml"));
-  interceptor->SetResponseOnIOThread("http://localhost/autoupdate/v2.crx",
-                                     basedir.AppendASCII("v2.crx"));
+  interceptor.SetResponse("http://localhost/autoupdate/manifest",
+                          basedir.AppendASCII("manifest_v2.xml"));
+  interceptor.SetResponse("http://localhost/autoupdate/v2.crx",
+                          basedir.AppendASCII("v2.crx"));
 
   // Check that the policy is initially empty.
   PrefService* prefs = browser()->profile()->GetPrefs();
   const ListValue* forcelist =
       prefs->GetList(prefs::kExtensionInstallForceList);
   ASSERT_TRUE(forcelist->empty()) << kForceInstallNotEmptyHelp;
 
   // User install of the extension.
   ASSERT_TRUE(InstallExtension(basedir.AppendASCII("v2.crx"), 1));
   ASSERT_EQ(size_before + 1, service->extensions()->size());
@@ skipping 56 matching lines @@
         std::string(kExtensionId) + ";http://localhost/autoupdate/manifest"));
   }
   ASSERT_TRUE(WaitForExtensionInstall());
   ASSERT_EQ(size_before + 1, service->extensions()->size());
   extension = service->GetExtensionById(kExtensionId, false);
   ASSERT_TRUE(extension);
   EXPECT_EQ(Extension::EXTERNAL_POLICY_DOWNLOAD, extension->location());
   EXPECT_TRUE(service->IsExtensionEnabled(kExtensionId));
   EXPECT_TRUE(service->disabled_extensions()->is_empty());
 }