Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 11293248: throw on Object.unobserve(obj, nonFunction) (Closed)

Created:
8 years, 1 month ago by rafaelw
Modified:
8 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

Object.unobserve(obj, callback) now throws a TypeError when callback is not a function. Committed: https://code.google.com/p/v8/source/detail?r=12950

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/object-observe.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/object-observe.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rafaelw
8 years, 1 month ago (2012-11-13 12:44:30 UTC) #1
rossberg
LGTM, will land it.
8 years, 1 month ago (2012-11-13 12:54:17 UTC) #2
arv (Not doing code reviews)
8 years, 1 month ago (2012-11-13 15:06:25 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698