Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1129323005: Check that only a single delegate for the Android PolicyProvider exists. (Closed)

Created:
5 years, 7 months ago by Bernhard Bauer
Modified:
5 years, 7 months ago
Reviewers:
bartfab (slow), knn, dgn
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check that only a single delegate for the Android PolicyProvider exists. BUG=484997 Committed: https://crrev.com/5b7f1bb0bdddcbf894b954041de7ad334f8236e2 Cr-Commit-Position: refs/heads/master@{#329378}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/policy/core/common/policy_provider_android.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Bernhard Bauer
Please review.
5 years, 7 months ago (2015-05-11 12:14:34 UTC) #2
knn
On 2015/05/11 12:14:34, Bernhard Bauer wrote: > Please review. LGTM
5 years, 7 months ago (2015-05-11 12:32:53 UTC) #3
Bernhard Bauer
+Bartosz for OWNERS review. Thanks!
5 years, 7 months ago (2015-05-11 13:57:44 UTC) #5
bartfab (slow)
lgtm
5 years, 7 months ago (2015-05-11 15:05:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129323005/1
5 years, 7 months ago (2015-05-12 08:51:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 08:55:25 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 08:56:04 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b7f1bb0bdddcbf894b954041de7ad334f8236e2
Cr-Commit-Position: refs/heads/master@{#329378}

Powered by Google App Engine
This is Rietveld 408576698