Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 1129323003: Allow callers of TimeSource::GetWallClockTime() to suspend time. (Closed)

Created:
5 years, 7 months ago by DaleCurtis
Modified:
5 years, 7 months ago
Reviewers:
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow callers of TimeSource::GetWallClockTime() to suspend time. [for discussion only currently] Adds acquire, release, and locked semantics to ensure time monotonicity between calls while converting multiple timestamps. GetWallClockTime() now takes a flags value which can be specified as: - SINGLE_TIMESTAMP (acquire + release in the same call) - SUSPEND_TIME (acquire, release in a later call) - RESUME_TIME (acquired previously, release in this call) - TIME_IS_SUSPENDED (acquired previously, do not release this call). A little hairy, but the other option is to pass a vector<base::TimeDelta> in and receive a vector<base::TimeTicks> out; which seems a bit overweight. BUG=485042 TEST=TBD if we end up going this route.

Patch Set 1 : Comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -53 lines) Patch
M media/base/mock_filters.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/base/time_source.h View 4 chunks +30 lines, -2 lines 0 comments Download
M media/base/video_renderer.h View 3 chunks +2 lines, -4 lines 0 comments Download
M media/base/wall_clock_time_source.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/base/wall_clock_time_source.cc View 1 chunk +18 lines, -6 lines 0 comments Download
M media/base/wall_clock_time_source_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M media/filters/video_renderer_algorithm.h View 2 chunks +3 lines, -5 lines 0 comments Download
M media/filters/video_renderer_algorithm.cc View 3 chunks +16 lines, -11 lines 0 comments Download
M media/renderers/audio_renderer_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/renderers/audio_renderer_impl.cc View 2 chunks +25 lines, -7 lines 0 comments Download
M media/renderers/renderer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M media/renderers/renderer_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/renderers/video_renderer_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/renderers/video_renderer_impl.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M media/renderers/video_renderer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
DaleCurtis
5 years, 7 months ago (2015-05-09 21:51:20 UTC) #2

          

Powered by Google App Engine
This is Rietveld 408576698