Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1129323002: Flatten media_router.js. (Closed)

Created:
5 years, 7 months ago by apacible
Modified:
5 years, 7 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flatten media_router.js. Add flattenhtml attribute to media_router.js, which <include>s media_router_data.js and media_router_ui_interface.js. Committed: https://crrev.com/b8e71d43d6c240970cf0878d7154f429ecd1db4c Cr-Commit-Position: refs/heads/master@{#329172}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/media_router_resources.grdp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
apacible
PTAL, thanks!
5 years, 7 months ago (2015-05-08 00:27:51 UTC) #2
James Hawkins
lgtm
5 years, 7 months ago (2015-05-08 18:52:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129323002/1
5 years, 7 months ago (2015-05-08 21:19:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/5513)
5 years, 7 months ago (2015-05-09 06:10:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129323002/1
5 years, 7 months ago (2015-05-09 06:59:02 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on ...
5 years, 7 months ago (2015-05-09 12:15:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129323002/1
5 years, 7 months ago (2015-05-10 05:49:10 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_rel on ...
5 years, 7 months ago (2015-05-10 09:52:21 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129323002/1
5 years, 7 months ago (2015-05-11 15:59:26 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 17:35:59 UTC) #18
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 17:37:22 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8e71d43d6c240970cf0878d7154f429ecd1db4c
Cr-Commit-Position: refs/heads/master@{#329172}

Powered by Google App Engine
This is Rietveld 408576698