Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 11293219: Merge 133983 - [Chromium] Arabic digits should appear left-to-right (Closed)

Created:
8 years, 1 month ago by bashi
Modified:
8 years, 1 month ago
Reviewers:
bashi
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 133983 - [Chromium] Arabic digits should appear left-to-right https://bugs.webkit.org/show_bug.cgi?id=101440 Reviewed by Tony Chang. Source/WebCore: Call hb_buffer_set_direction() to set direction when drawing glyphs or direction should be overridden. Leave direction setting to HarfBuzz when WebKit is calculating widths because the direction is LTR by default while calculating widths. Set script before shaping so that HarfBuzz can estimate appropriate direction. Test: fast/text/international/arabic-digits.html * platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp: (WebCore::HarfBuzzShaper::HarfBuzzRun::HarfBuzzRun): Add m_script. This holds the script of the run. (WebCore::HarfBuzzShaper::shape): Tell shapeHarfBuzzRuns() to set direction when drawing glyphs or direction should be overridden. (WebCore::HarfBuzzShaper::collectHarfBuzzRuns): Set script of HarfBuzzRuns. (WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Add an argument that indicates it should set direction. * platform/graphics/harfbuzz/ng/HarfBuzzShaper.h: (WebCore::HarfBuzzShaper::HarfBuzzRun::create): (WebCore::HarfBuzzShaper::HarfBuzzRun::rtl): (WebCore::HarfBuzzShaper::HarfBuzzRun::script): (HarfBuzzRun): (HarfBuzzShaper): LayoutTests: Add a test that checks Arabic digits appear in increasing order from left to right. * fast/text/international/arabic-digits-expected.html: Added. * fast/text/international/arabic-digits.html: Added. TBR=bashi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134172

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
A + LayoutTests/fast/text/international/arabic-digits.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/text/international/arabic-digits-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.h View 3 chunks +7 lines, -5 lines 0 comments Download
M Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp View 5 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
bashi
8 years, 1 month ago (2012-11-11 13:10:10 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698