Issue 11293210: Move global_descriptors to base/posix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11293210: Move global_descriptors to base/posix. (Closed)

Created:
8 years, 1 month ago by brettw

Modified:
8 years, 1 month ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, erikwright+watch_chromium.org, native-client-reviews_googlegroups.com, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move global_descriptors to base/posix. This file represents a posix-only concept. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167008

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -154 lines)			Patch
M	base/base.gypi	View	2 chunks	+2 lines, -2 lines	0 comments	Download
D	base/global_descriptors_posix.h	View	1 chunk	+0 lines, -70 lines	0 comments	Download
D	base/global_descriptors_posix.cc	View	1 chunk	+0 lines, -60 lines	0 comments	Download
A +	base/posix/global_descriptors.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	base/posix/global_descriptors.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/app/breakpad_linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/android/crash_dump_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/nacl/nacl_helper_linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/app/android/sandboxed_process_service.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/app/content_main_runner.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/child_process_launcher.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/common/child_process_sandbox_support_impl_linux.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/plugin/plugin_main.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/browser/content_browser_client.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/common/content_descriptors.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/shell/android/shell_descriptors.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/shell/shell_main_delegate.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/zygote/zygote_linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ipc/ipc_channel_posix.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ipc/ipc_descriptors.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ipc/ipc_multiprocess_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

8 years, 1 month ago (2012-11-09 21:45:25 UTC) #2

lgtm, but I don't have owners in most of these directories.

Expand Messages | Collapse Messages