Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

Issue 11293197: Fix warnings in mirror implementation's diagnostic listener. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart
diff --git a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart
index fe4e6da855f1e3b705f00079eae712c329914f26..8fbb03efbb64a36535799cff08df439b8478626c 100644
--- a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart
+++ b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart
@@ -177,12 +177,24 @@ class Dart2JsDiagnosticListener implements DiagnosticListener {
void internalError(String message,
{Node node, Token token, HInstruction instruction,
Element element}) {
- cancel('Internal error: $message', node, token, instruction, element);
+ cancel('Internal error: $message', node: node, token: token,
+ instruction: instruction, element: element);
}
void internalErrorOnElement(Element element, String message) {
internalError(message, element: element);
}
+
+ SourceSpan spanFromNode(Node node, [Uri uri]) {
+ // TODO(johnniwinther): implement this.
+ throw 'unimplemented';
+ }
+
+ void reportMessage(SourceSpan span, Diagnostic message,
+ diagnostics.Diagnostic kind) {
+ // TODO(johnniwinther): implement this.
+ throw 'unimplemented';
+ }
}
//------------------------------------------------------------------------------
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698