cc/occlusion_tracker_unittest.cc - Issue 11293194: ui: Prefer +/- operators to apply offsets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/occlusion_tracker_unittest.cc

Issue 11293194: ui: Prefer +/- operators to apply offsets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: floats Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/occlusion_tracker_unittest.cc

diff --git a/cc/occlusion_tracker_unittest.cc b/cc/occlusion_tracker_unittest.cc

index babd9cd82f10761377766e94ab6936ee63757bdc..187ab21c7e8c39da71125bb6a7d509b9ce595ef5 100644

--- a/cc/occlusion_tracker_unittest.cc

+++ b/cc/occlusion_tracker_unittest.cc

@@ -905,22 +905,22 @@ protected:

EXPECT_TRUE(occlusion.occludedLayer(child, clippedLayerInChild));

EXPECT_TRUE(occlusion.unoccludedLayerContentRect(child, clippedLayerInChild).IsEmpty());

- clippedLayerInChild.Offset(-1, 0);

+ clippedLayerInChild += gfx::Vector2d(-1, 0);

EXPECT_FALSE(occlusion.occludedLayer(child, clippedLayerInChild));

EXPECT_FALSE(occlusion.unoccludedLayerContentRect(child, clippedLayerInChild).IsEmpty());

- clippedLayerInChild.Offset(1, 0);

+ clippedLayerInChild += gfx::Vector2d(1, 0);

EXPECT_FALSE(occlusion.occludedLayer(child, clippedLayerInChild));

EXPECT_FALSE(occlusion.unoccludedLayerContentRect(child, clippedLayerInChild).IsEmpty());

- clippedLayerInChild.Offset(-1, 0);

- clippedLayerInChild.Offset(0, -1);

+ clippedLayerInChild += gfx::Vector2d(-1, 0);

+ clippedLayerInChild += gfx::Vector2d(0, -1);

EXPECT_FALSE(occlusion.occludedLayer(child, clippedLayerInChild));

EXPECT_FALSE(occlusion.unoccludedLayerContentRect(child, clippedLayerInChild).IsEmpty());

- clippedLayerInChild.Offset(0, 1);

+ clippedLayerInChild += gfx::Vector2d(0, 1);

EXPECT_FALSE(occlusion.occludedLayer(child, clippedLayerInChild));

EXPECT_FALSE(occlusion.unoccludedLayerContentRect(child, clippedLayerInChild).IsEmpty());

- clippedLayerInChild.Offset(0, -1);

+ clippedLayerInChild += gfx::Vector2d(0, -1);

this->leaveContributingSurface(child, occlusion);

this->enterLayer(parent, occlusion);