Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: ui/gfx/vector2d_unittest.cc

Issue 11293193: ui: Add non-member Vector2dScale() and Vector3dScale() methods to create scaled vectors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: use it in cc/ Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/vector2d_unittest.cc
diff --git a/ui/gfx/vector2d_unittest.cc b/ui/gfx/vector2d_unittest.cc
index ccb6059e2420793540cd4bafb82b14fd17f86597..0db36f63477f6accae5aa0a2d1ea1a9912f80786 100644
--- a/ui/gfx/vector2d_unittest.cc
+++ b/ui/gfx/vector2d_unittest.cc
@@ -115,6 +115,12 @@ TEST(Vector2dTest, Scale) {
v.Scale(double_values[i][2], double_values[i][3]);
EXPECT_EQ(v.x(), double_values[i][0] * double_values[i][2]);
EXPECT_EQ(v.y(), double_values[i][1] * double_values[i][3]);
+
+ Vector2dF v2 = ScaleVector2d(
+ gfx::Vector2dF(double_values[i][0], double_values[i][1]),
+ double_values[i][2], double_values[i][3]);
+ EXPECT_EQ(v2.x(), double_values[i][0] * double_values[i][2]);
sky 2012/11/09 17:06:21 Your The order is wrong here. You want expected,ac
danakj 2012/11/09 18:21:47 Oops, thanks.
+ EXPECT_EQ(v2.y(), double_values[i][1] * double_values[i][3]);
}
float single_values[][3] = {
@@ -134,6 +140,12 @@ TEST(Vector2dTest, Scale) {
v.Scale(single_values[i][2]);
EXPECT_EQ(v.x(), single_values[i][0] * single_values[i][2]);
EXPECT_EQ(v.y(), single_values[i][1] * single_values[i][2]);
+
+ Vector2dF v2 = ScaleVector2d(
+ gfx::Vector2dF(double_values[i][0], double_values[i][1]),
+ double_values[i][2]);
+ EXPECT_EQ(v2.x(), single_values[i][0] * single_values[i][2]);
+ EXPECT_EQ(v2.y(), single_values[i][1] * single_values[i][2]);
}
}

Powered by Google App Engine
This is Rietveld 408576698