Throw illegal argument exception when

Throw illegal argument exception when
- objects which extend NativeWrapper are passed in isolate messages
- closure objects are passed in isolate messages
(issues 6108, 6312)
Committed: https://code.google.com/p/dart/source/detail?r=14926

[siva, 2012-11-12 19:32:06]

synched up to TOT.

[Ivan Posva, 2012-11-13 08:12:46]

http://codereview.chromium.org/11293163/diff/17001/vm/base_isolate.h
File vm/base_isolate.h (right):

http://codereview.chromium.org/11293163/diff/17001/vm/base_isolate.h#newcode83
vm/base_isolate.h:83: void ResetNoGCScopeDepth() {
As discussed in person we should try to avoid the reset of No*Scope and instead
find a more suitable mechanism.

[siva, 2012-11-13 19:46:54]

Addressed comment, PTAL.

http://codereview.chromium.org/11293163/diff/17001/vm/base_isolate.h
File vm/base_isolate.h (right):

http://codereview.chromium.org/11293163/diff/17001/vm/base_isolate.h#newcode83
vm/base_isolate.h:83: void ResetNoGCScopeDepth() {
Done.

Now a longjmp is done at the point of failure and the
enclosing writer throws the exception.

On 2012/11/13 08:12:46, Ivan Posva wrote:
> As discussed in person we should try to avoid the reset of No*Scope and
instead
> find a more suitable mechanism.

[Ivan Posva, 2012-11-14 05:12:15]

https://codereview.chromium.org/11293163/diff/16002/vm/snapshot.cc
File vm/snapshot.cc (right):

https://codereview.chromium.org/11293163/diff/16002/vm/snapshot.cc#newcode1222
vm/snapshot.cc:1222: String::Handle(String::New("Error while writing script
snapshot")));
Can these strings be in the shared symbol table to avoid allocating a new string
on every message being sent?

https://codereview.chromium.org/11293163/diff/16002/vm/snapshot.cc#newcode1232
vm/snapshot.cc:1232: ThrowException(exception_type(), exception_msg());
What happens to the long jump base in case we are throwing an exception?

[siva, 2012-11-14 18:26:38]

https://codereview.chromium.org/11293163/diff/16002/vm/snapshot.cc
File vm/snapshot.cc (right):

https://codereview.chromium.org/11293163/diff/16002/vm/snapshot.cc#newcode1222
vm/snapshot.cc:1222: String::Handle(String::New("Error while writing script
snapshot")));
Instead of using the symbol table we should probably
have these constant strings be created in the VM isolate
as singletons. We have a number of these singletons in the
VM code.

I have added a TODO here to setup an infrastructure for
singleton string objects and all these can move into that.

On 2012/11/14 05:12:15, Ivan Posva wrote:
> Can these strings be in the shared symbol table to avoid allocating a new
string
> on every message being sent?

https://codereview.chromium.org/11293163/diff/16002/vm/snapshot.cc#newcode1232
vm/snapshot.cc:1232: ThrowException(exception_type(), exception_msg());
Good point, reset base back before throwing the exception.

On 2012/11/14 05:12:15, Ivan Posva wrote:
> What happens to the long jump base in case we are throwing an exception?

[Ivan Posva, 2012-11-14 19:47:50]

LGTM -ip