Add a new ContentRendererClient::HandleNavigation callback in RenderViewImpl::decidePolicyForNaviga…

content/public/renderer/content_renderer_client.h

Index: content/public/renderer/content_renderer_client.h
===================================================================
--- content/public/renderer/content_renderer_client.h	(revision 165669)
+++ content/public/renderer/content_renderer_client.h	(working copy)
@@ -12,6 +12,8 @@
 #include "ipc/ipc_message.h"
 #include "content/public/common/content_client.h"
 #include "content/public/common/page_transition_types.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebNavigationPolicy.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebNavigationType.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebPageVisibilityState.h"
 #include "v8/include/v8.h"
 
@@ -130,6 +132,13 @@
   // Returns true if the given url can create popup windows.
   virtual bool AllowPopup(const GURL& creator);
 
+  // Returns true if the navigation was handled and should be ignored by WebKit.

[Charlie Reis, 2012/11/08 19:24:51]

nit: was handled by the embedder

[Marshall, 2012/11/08 19:32:36]

Done.

+  virtual bool HandleNavigation(WebKit::WebFrame* frame,

[Charlie Reis, 2012/11/08 19:24:51]

John, maybe this should be DidHandleNavigation?

That seems more consistent with similar APIs we have in the Chromium WebKit API,
though I guess there are other "Handle" methods below.

[Marshall, 2012/11/08 19:32:36]

I'm OK with whatever name is preferred.

[jam, 2012/11/08 21:10:07]

I think the "Did" prefix would be applicable when the function is just informing
the embedder of something. Since this has a return value and can change state,
the current name is good.

+                                const WebKit::WebURLRequest& request,
+                                WebKit::WebNavigationType type,
+                                WebKit::WebNavigationPolicy default_policy,
+                                bool is_redirect);
+
   // Returns true if we should fork a new process for the given navigation.
   virtual bool ShouldFork(WebKit::WebFrame* frame,
                           const GURL& url,