Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: ui/message_center/message_bubble_base.cc

Issue 11293124: Remove top and bottom margins from TrayBubbleView (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments addressed. Restored previous behavior on Windows non-aura. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/message_center/message_bubble_base.cc
diff --git a/ui/message_center/message_bubble_base.cc b/ui/message_center/message_bubble_base.cc
index 3688049d0f7ab3236517d84a3202c2fa4a263612..a22e98e47979f2e547a22843921283ae9afbdbeb 100644
--- a/ui/message_center/message_bubble_base.cc
+++ b/ui/message_center/message_bubble_base.cc
@@ -60,7 +60,11 @@ views::TrayBubbleView::InitParams MessageBubbleBase::GetDefaultInitParams(
views::TrayBubbleView::ANCHOR_TYPE_TRAY,
anchor_alignment,
kNotificationBubbleWidth);
+#if defined(OS_WIN) && !defined(USE_AURA)
+ // On Windows non-aura, there is a margin filled with |top_color| at the top
+ // of the bubble.
init_params.top_color = kBackgroundColor;
+#endif
init_params.arrow_color = kHeaderBackgroundColorDark;
init_params.bubble_width = kWebNotificationWidth;
return init_params;

Powered by Google App Engine
This is Rietveld 408576698