Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 11293111: Revert 166085 - Selective build clobbering feature (landmines.py and android build scripts). (Closed)

Created:
8 years, 1 month ago by vandebo (ex-Chrome)
Modified:
8 years, 1 month ago
Reviewers:
Lei Zhang, iannucci
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Revert 166085 - Selective build clobbering feature (landmines.py and android build scripts). It looks like this made win extract_build fail. Adds the ability for devs/troopers/etc. to set 'landmines' in the tree so that the build will selectively clobber when a builder moves over a revision with such a change. This cl has an basis landmines.py, and hooks the clobber mechanism to the android build scripts. The relevant cl which implements this for compile.py is here: https://chromiumcodereview.appspot.com/11234013/ I'm planning to also implement an informational invocation for gclient to let devs know about any potential landmines so they can decide if they need to clobber. R=cmp,maruel@chromium.org BUG=121897 Review URL: https://chromiumcodereview.appspot.com/11175016 TBR=iannucci@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166105

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -294 lines) Patch
M DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M build/android/buildbot/buildbot_functions.sh View 2 chunks +16 lines, -31 lines 0 comments Download
M build/gyp_chromium View 3 chunks +34 lines, -2 lines 0 comments Download
D build/gyp_helper.py View 1 chunk +0 lines, -48 lines 0 comments Download
D build/landmines.py View 1 chunk +0 lines, -208 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vandebo (ex-Chrome)
8 years, 1 month ago (2012-11-06 01:53:19 UTC) #1
Lei Zhang
http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/30416 Processing archive: e:\b\build\slave\Vista_Tests__1_\build\full-build-win32.zip Extracting full-build-win32\.landmines Data Error ... Sub items Errors: 1 Failed to ...
8 years, 1 month ago (2012-11-06 02:48:11 UTC) #2
iannucci
8 years, 1 month ago (2012-11-06 03:16:49 UTC) #3
Yeah you're right, that's a problem, we should revert.


On Mon, Nov 5, 2012 at 6:48 PM, <thestig@chromium.org> wrote:

> http://build.chromium.org/p/**chromium.win/builders/Vista%**
>
20Tests%20%281%29/builds/30416<http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/30416>
>
> Processing archive: e:\b\build\slave\Vista_Tests__**
> 1_\build\full-build-win32.zip
>
> Extracting  full-build-win32\.landmines     Data Error
> ...
> Sub items Errors: 1
>
> Failed to extract the build.
>
>
https://codereview.chromium.**org/11293111/<https://codereview.chromium.org/1...
>

Powered by Google App Engine
This is Rietveld 408576698