Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/autofill/wallet/wallet_items_unittest.cc

Issue 11293078: Integrating Online Wallet into Chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase and most fixes from Albert's initial review. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/autofill/wallet/wallet_items.cc ('K') | « chrome/browser/autofill/wallet/wallet_items.cc ('k') | chrome/browser/autofill/wallet/wallet_service_url.h » ('j') | chrome/browser/autofill/wallet/wallet_service_url.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/wallet/wallet_items_unittest.cc
diff --git a/chrome/browser/autofill/wallet/wallet_items_unittest.cc b/chrome/browser/autofill/wallet/wallet_items_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d3c0845b683e2388c54d8da327bca83d5d19d668
--- /dev/null
+++ b/chrome/browser/autofill/wallet/wallet_items_unittest.cc
@@ -0,0 +1,438 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/json/json_reader.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/values.h"
+#include "chrome/browser/autofill/wallet/wallet_items.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+static const char kMaskedInstrument[] =
+ "{"
+ " \"descriptive_name\":\"descriptive_name\","
+ " \"type\":\"VISA\","
+ " \"supported_currency\":"
+ " ["
+ " \"currency\""
+ " ],"
+ " \"last_four_digits\":\"last_four_digits\","
+ " \"expiration_month\":12,"
+ " \"expiration_year\":2012,"
+ " \"brand\":\"brand\","
+ " \"billing_address\":"
+ " {"
+ " \"name\":\"name\","
+ " \"address1\":\"address1\","
+ " \"address2\":\"address2\","
+ " \"city\":\"city\","
+ " \"state\":\"state\","
+ " \"postal_code\":\"postal_code\","
+ " \"phone_number\":\"phone_number\","
+ " \"country_code\":\"country_code\""
+ " },"
+ " \"status\":\"VALID\","
+ " \"object_id\":\"object_id\""
+ "}";
+
+static const char kMaskedInstrumentMissingStatus[] =
+ "{"
+ " \"descriptive_name\":\"descriptive_name\","
+ " \"type\":\"VISA\","
+ " \"supported_currency\":"
+ " ["
+ " \"currency\""
+ " ],"
+ " \"last_four_digits\":\"last_four_digits\","
+ " \"expiration_month\":12,"
+ " \"expiration_year\":2012,"
+ " \"brand\":\"brand\","
+ " \"billing_address\":"
+ " {"
+ " \"name\":\"name\","
+ " \"address1\":\"address1\","
+ " \"address2\":\"address2\","
+ " \"city\":\"city\","
+ " \"state\":\"state\","
+ " \"postal_code\":\"postal_code\","
+ " \"phone_number\":\"phone_number\","
+ " \"country_code\":\"country_code\""
+ " },"
+ " \"object_id\":\"object_id\""
+ "}";
+
+static const char kMaskedInstrumentMissingType[] =
+ "{"
+ " \"descriptive_name\":\"descriptive_name\","
+ " \"supported_currency\":"
+ " ["
+ " \"currency\""
+ " ],"
+ " \"last_four_digits\":\"last_four_digits\","
+ " \"expiration_month\":12,"
+ " \"expiration_year\":2012,"
+ " \"brand\":\"brand\","
+ " \"billing_address\":"
+ " {"
+ " \"name\":\"name\","
+ " \"address1\":\"address1\","
+ " \"address2\":\"address2\","
+ " \"city\":\"city\","
+ " \"state\":\"state\","
+ " \"postal_code\":\"postal_code\","
+ " \"phone_number\":\"phone_number\","
+ " \"country_code\":\"country_code\""
+ " },"
+ " \"status\":\"VALID\","
+ " \"object_id\":\"object_id\""
+ "}";
+
+static const char kMaskedInstrumentMissingLastFourDigits[] =
+ "{"
+ " \"descriptive_name\":\"descriptive_name\","
+ " \"type\":\"VISA\","
+ " \"supported_currency\":"
+ " ["
+ " \"currency\""
+ " ],"
+ " \"expiration_month\":12,"
+ " \"expiration_year\":2012,"
+ " \"brand\":\"brand\","
+ " \"billing_address\":"
+ " {"
+ " \"name\":\"name\","
+ " \"address1\":\"address1\","
+ " \"address2\":\"address2\","
+ " \"city\":\"city\","
+ " \"state\":\"state\","
+ " \"postal_code\":\"postal_code\","
+ " \"phone_number\":\"phone_number\","
+ " \"country_code\":\"country_code\""
+ " },"
+ " \"status\":\"VALID\","
+ " \"object_id\":\"object_id\""
+ "}";
+
+static const char kMaskedInstrumentMissingAddress[] =
+ "{"
+ " \"descriptive_name\":\"descriptive_name\","
+ " \"type\":\"VISA\","
+ " \"supported_currency\":"
+ " ["
+ " \"currency\""
+ " ],"
+ " \"last_four_digits\":\"last_four_digits\","
+ " \"expiration_month\":12,"
+ " \"expiration_year\":2012,"
+ " \"brand\":\"brand\","
+ " \"status\":\"VALID\","
+ " \"object_id\":\"object_id\""
+ "}";
+
+static const char kMaskedInstrumentMalformedAddress[] =
+ "{"
+ " \"descriptive_name\":\"descriptive_name\","
+ " \"type\":\"VISA\","
+ " \"supported_currency\":"
+ " ["
+ " \"currency\""
+ " ],"
+ " \"last_four_digits\":\"last_four_digits\","
+ " \"expiration_month\":12,"
+ " \"expiration_year\":2012,"
+ " \"brand\":\"brand\","
+ " \"billing_address\":"
+ " {"
+ " \"address1\":\"address1\","
+ " \"address2\":\"address2\","
+ " \"city\":\"city\","
+ " \"state\":\"state\","
+ " \"phone_number\":\"phone_number\","
+ " \"country_code\":\"country_code\""
+ " },"
+ " \"status\":\"VALID\","
+ " \"object_id\":\"object_id\""
+ "}";
+
+static const char kMaskedInstrumentMissingObjectId[] =
+ "{"
+ " \"descriptive_name\":\"descriptive_name\","
+ " \"type\":\"VISA\","
+ " \"supported_currency\":"
+ " ["
+ " \"currency\""
+ " ],"
+ " \"last_four_digits\":\"last_four_digits\","
+ " \"expiration_month\":12,"
+ " \"expiration_year\":2012,"
+ " \"brand\":\"brand\","
+ " \"billing_address\":"
+ " {"
+ " \"name\":\"name\","
+ " \"address1\":\"address1\","
+ " \"address2\":\"address2\","
+ " \"city\":\"city\","
+ " \"state\":\"state\","
+ " \"postal_code\":\"postal_code\","
+ " \"phone_number\":\"phone_number\","
+ " \"country_code\":\"country_code\""
+ " },"
+ " \"status\":\"VALID\""
+ "}";
+
+static const char kLegalDocument[] =
+ "{"
+ " \"legal_document_id\":\"doc_id\","
+ " \"display_name\":\"display_name\","
+ " \"document\":\"doc_body\""
+ "}";
+
+static const char kLegalDocumentMissingDocumentId[] =
+ "{"
+ " \"display_name\":\"display_name\","
+ " \"document\":\"doc_body\""
+ "}";
+
+static const char kLegalDocumentMissingDisplayName[] =
+ "{"
+ " \"legal_document_id\":\"doc_id\","
+ " \"document\":\"doc_body\""
+ "}";
+
+static const char kLegalDocumentMissingDocumentBody[] =
+ "{"
+ " \"legal_document_id\":\"doc_id\","
+ " \"display_name\":\"display_name\""
+ "}";
+
+static const char kWalletItemsWithRequiredActions[] =
+ "{"
+ " \"required_action\":"
+ " ["
+ " \"required_action\""
+ " ]"
+ "}";
+
+static const char kWalletItems[] =
+ "{"
+ " \"required_action\":"
+ " ["
+ " ],"
+ " \"google_transaction_id\":\"google_transaction_id\","
+ " \"instrument\":"
+ " ["
+ " {"
+ " \"descriptive_name\":\"descriptive_name\","
+ " \"type\":\"VISA\","
+ " \"supported_currency\":"
+ " ["
+ " \"currency\""
+ " ],"
+ " \"last_four_digits\":\"last_four_digits\","
+ " \"expiration_month\":12,"
+ " \"expiration_year\":2012,"
+ " \"brand\":\"brand\","
+ " \"billing_address\":"
+ " {"
+ " \"name\":\"name\","
+ " \"address1\":\"address1\","
+ " \"address2\":\"address2\","
+ " \"city\":\"city\","
+ " \"state\":\"state\","
+ " \"postal_code\":\"postal_code\","
+ " \"phone_number\":\"phone_number\","
+ " \"country_code\":\"country_code\""
+ " },"
+ " \"status\":\"VALID\","
+ " \"object_id\":\"object_id\""
+ " }"
+ " ],"
+ " \"default_instrument_id\":\"default_instrument_id\","
+ " \"address\":"
+ " ["
+ " {"
+ " \"id\":\"id\","
+ " \"phone_number\":\"phone_number\","
+ " \"postal_address\":"
+ " {"
+ " \"recipient_name\":\"recipient_name\","
+ " \"address_line_1\":\"address_line_1\","
+ " \"address_line_2\":\"address_line_2\","
+ " \"locality_name\":\"locality_name\","
+ " \"administrative_area_name\":\"administrative_area_name\","
+ " \"postal_code_number\":\"postal_code_number\","
+ " \"country_name_code\":\"country_name_code\""
+ " }"
+ " }"
+ " ],"
+ " \"default_address_id\":\"default_address_id\","
+ " \"required_legal_document\":"
+ " ["
+ " {"
+ " \"legal_document_id\":\"doc_id\","
+ " \"display_name\":\"display_name\","
+ " \"document\":\"doc_body\""
+ " }"
+ " ]"
+ "}";
+
+} // end anonymous namespace
+
+namespace wallet {
+
+class WalletItemsTest : public testing::Test {
+ public:
+ WalletItemsTest() {}
+ virtual void SetUp() {
+ dict.reset();
+ }
+ protected:
+ void SetUpDictionary(const std::string& json) {
+ scoped_ptr<Value> value(base::JSONReader::Read(json));
+ if (value.get() && value->IsType(Value::TYPE_DICTIONARY)) {
+ dict.reset(static_cast<DictionaryValue*>(value.release()));
+ }
+ }
+ scoped_ptr<DictionaryValue> dict;
+};
+
+TEST_F(WalletItemsTest, CreateMaskedInstrumentMissingStatus) {
+ SetUpDictionary(kMaskedInstrumentMissingStatus);
+ ASSERT_EQ(NULL,
+ WalletItems::MaskedInstrument::CreateMaskedInstrument(dict.get()));
+}
+
+TEST_F(WalletItemsTest, CreateMaskedInstrumentMissingType) {
+ SetUpDictionary(kMaskedInstrumentMissingType);
+ ASSERT_EQ(NULL,
+ WalletItems::MaskedInstrument::CreateMaskedInstrument(dict.get()));
+}
+
+TEST_F(WalletItemsTest, CreateMaskedInstrumentMissingLastFourDigits) {
+ SetUpDictionary(kMaskedInstrumentMissingLastFourDigits);
+ ASSERT_EQ(NULL,
+ WalletItems::MaskedInstrument::CreateMaskedInstrument(dict.get()));
+}
+
+TEST_F(WalletItemsTest, CreateMaskedInstrumentMissingAddress) {
+ SetUpDictionary(kMaskedInstrumentMissingAddress);
+ ASSERT_EQ(NULL,
+ WalletItems::MaskedInstrument::CreateMaskedInstrument(dict.get()));
+}
+
+TEST_F(WalletItemsTest, CreateMaskedInstrumentMalformedAddress) {
+ SetUpDictionary(kMaskedInstrumentMalformedAddress);
+ ASSERT_EQ(NULL,
+ WalletItems::MaskedInstrument::CreateMaskedInstrument(dict.get()));
+}
+
+TEST_F(WalletItemsTest, CreateMaskedInstrumentMissingObjectId) {
+ SetUpDictionary(kMaskedInstrumentMissingObjectId);
+ ASSERT_EQ(NULL,
+ WalletItems::MaskedInstrument::CreateMaskedInstrument(dict.get()));
+}
+
+TEST_F(WalletItemsTest, CreateMaskedInstrument) {
+ SetUpDictionary(kMaskedInstrument);
+ Address* address = new Address("country_code",
Dan Beam 2012/12/01 01:19:49 does ~MaskedInstrument delete |address|? else the
ahutter 2012/12/01 04:06:51 Yeah, address goes into a scoped_ptr in the constr
+ "name",
+ "address1",
+ "address2",
+ "city",
+ "state",
+ "postal_code",
+ "phone_number",
+ "");
+ std::vector<std::string> supported_currencies;
+ supported_currencies.push_back("currency");
+ WalletItems::MaskedInstrument masked_instrument(
+ "descriptive_name",
+ WalletItems::MaskedInstrument::VISA,
+ supported_currencies,
+ "last_four_digits",
+ 12,
+ 2012,
+ "brand",
+ address,
+ WalletItems::MaskedInstrument::VALID,
+ "object_id");
+ ASSERT_EQ(masked_instrument,
+ *WalletItems::MaskedInstrument::CreateMaskedInstrument(dict.get()));
+}
+
+TEST_F(WalletItemsTest, CreateLegalDocumentMissingDocId) {
+ SetUpDictionary(kLegalDocumentMissingDocumentId);
+ ASSERT_EQ(NULL, WalletItems::LegalDocument::CreateLegalDocument(dict.get()));
+}
+
+TEST_F(WalletItemsTest, CreateLegalDocumentMissingDisplayName) {
+ SetUpDictionary(kLegalDocumentMissingDisplayName);
+ ASSERT_EQ(NULL, WalletItems::LegalDocument::CreateLegalDocument(dict.get()));
+}
+
+TEST_F(WalletItemsTest, CreateLegalDocumentMissingDocBody) {
+ SetUpDictionary(kLegalDocumentMissingDocumentBody);
+ ASSERT_EQ(NULL, WalletItems::LegalDocument::CreateLegalDocument(dict.get()));
+}
+
+TEST_F(WalletItemsTest, CreateLegalDocument) {
+ SetUpDictionary(kLegalDocument);
+ WalletItems::LegalDocument expected("doc_id", "display_name", "doc_body");
+ ASSERT_EQ(expected,
+ *WalletItems::LegalDocument::CreateLegalDocument(dict.get()));
+}
+
+TEST_F(WalletItemsTest, CreateWalletItemsWithRequiredActions) {
+ SetUpDictionary(kWalletItemsWithRequiredActions);
+ std::vector<std::string> required_actions;
+ required_actions.push_back("required_action");
+ WalletItems expected(required_actions,
Dan Beam 2012/12/01 01:19:49 nit: WalletItems expected(required_actions, "",
ahutter 2012/12/01 04:06:51 Done.
+ "",
+ "",
+ "");
+ ASSERT_EQ(expected, *WalletItems::CreateWalletItems(dict.get()));
+}
+
+TEST_F(WalletItemsTest, CreateWalletItems) {
+ SetUpDictionary(kWalletItems);
+ Address* address = new Address("country_code",
+ "name",
+ "address1",
+ "address2",
+ "city",
+ "state",
+ "postal_code",
+ "phone_number",
+ "");
+ std::vector<std::string> supported_currencies;
+ supported_currencies.push_back("currency");
+ WalletItems::MaskedInstrument* masked_instrument =
+ new WalletItems::MaskedInstrument("descriptive_name",
+ WalletItems::MaskedInstrument::VISA,
+ supported_currencies,
+ "last_four_digits",
+ 12,
+ 2012,
+ "brand",
+ address,
+ WalletItems::MaskedInstrument::VALID,
+ "object_id");
+ WalletItems::LegalDocument* legal_document =
+ new WalletItems::LegalDocument("doc_id",
+ "display_name",
+ "doc_body");
+ std::vector<std::string> required_actions;
+ WalletItems expected(required_actions,
+ "google_transaction_id",
+ "default_instrument_id",
+ "default_address_id");
+ expected.AddInstrument(masked_instrument);
+ // TODO(ahutter): add an address
+ // expected.AddAddress(address);
Dan Beam 2012/12/01 01:19:49 nit: don't keep commented out source code, IMO
ahutter 2012/12/01 04:06:51 Done.
+ expected.AddLegalDocument(legal_document);
+ ASSERT_EQ(expected, *WalletItems::CreateWalletItems(dict.get()));
+}
+
+} // end wallet namespace
« chrome/browser/autofill/wallet/wallet_items.cc ('K') | « chrome/browser/autofill/wallet/wallet_items.cc ('k') | chrome/browser/autofill/wallet/wallet_service_url.h » ('j') | chrome/browser/autofill/wallet/wallet_service_url.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698