Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3200)

Unified Diff: base/string_number_conversions.h

Issue 11293078: Integrating Online Wallet into Chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixes from Raman's code review Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/string_number_conversions.cc » ('j') | chrome/browser/autofill/wallet/cart.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/string_number_conversions.h
diff --git a/base/string_number_conversions.h b/base/string_number_conversions.h
index 54f05b0954327dfdc2c91404a77b7973b079f58c..19b281c40f505070eb5178202ef5e9b331e2c242 100644
--- a/base/string_number_conversions.h
+++ b/base/string_number_conversions.h
@@ -95,6 +95,8 @@ BASE_EXPORT std::string HexEncode(const void* bytes, size_t size);
// Best effort conversion, see StringToInt above for restrictions.
BASE_EXPORT bool HexStringToInt(const StringPiece& input, int* output);
+BASE_EXPORT bool HexStringToInt64(const StringPiece& input, int64* output);
Albert Bodenhamer 2012/11/28 23:50:56 You should probably add a new test in base/string_
+
// Similar to the previous functions, except that output is a vector of bytes.
// |*output| will contain as many bytes as were successfully parsed prior to the
// error. There is no overflow, but input.size() must be evenly divisible by 2.
@@ -105,4 +107,3 @@ BASE_EXPORT bool HexStringToBytes(const std::string& input,
} // namespace base
#endif // BASE_STRING_NUMBER_CONVERSIONS_H_
Albert Bodenhamer 2012/11/28 23:50:56 Looks like a whitespace change.
ahutter 2012/11/29 20:52:38 Yeah, the .vimrc file Google provides is doing som
-
« no previous file with comments | « no previous file | base/string_number_conversions.cc » ('j') | chrome/browser/autofill/wallet/cart.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698