Integrating Online Wallet into Chrome.

chrome/common/chrome_switches.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_switches.h"
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
 
 namespace switches {
@@ skipping 1342 matching lines @@
 // Prints version information and quits.
 const char kVersion[]                       = "version";
 
 // Requests that Chrome connect to a remote viewer process using an IPC
 // channel of the given name.
 const char kViewerConnection[]              = "viewer-connection";
 
 // Cycle through a series of URLs listed in the specified file.
 const char kVisitURLs[]                     = "visit-urls";
 
+// Secure service URL for Online Wallet service.
+const char kWalletSecureServiceUrl[]        = "wallet-secure-service-url";
+
+// Service URL for Online Wallet service.
+const char kWalletServiceUrl[]              = "wallet-service-url";

[Ilya Sherman, 2012/12/15 01:40:12]

Why do we have a non-secure URL (that we're willing to use) for the service? 
These flags should probably be documented better to explain what they mean.

[ahutter, 2012/12/15 02:22:22]

Done.

[benquan, 2012/12/15 02:48:59]

I would suggest to use a different word other than "secure", as people leaning
to think about "https:" when they saw "secure" and "url" in the constant name.

On 2012/12/15 02:22:22, ahutter wrote:

[ahutter, 2012/12/17 17:23:02]

Added some comments.

+
 // Enable the "native services" feature of web-intents.
 const char kWebIntentsNativeServicesEnabled[] =
     "web-intents-native-services-enabled";
 
 // Enable invocation of web intents from web content.
 const char kWebIntentsInvocationEnabled[] =
     "enable-web-intents-invocation";
 
 // Adds the given extension ID to all the permission whitelists.
 const char kWhitelistedExtensionID[]        = "whitelisted-extension-id";
@@ skipping 265 matching lines @@
 #elif defined(OS_WIN)
   return CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kEnableChromeStyleDialogs);
 #else
   return CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kEnableChromeStyleDialogs);
 #endif
 }
 
 }  // namespace chrome