Integrating Online Wallet into Chrome.

chrome/common/chrome_switches.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_switches.h"
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
 
 namespace switches {
@@ skipping 1328 matching lines @@
 // Prints version information and quits.
 const char kVersion[]                       = "version";
 
 // Requests that Chrome connect to a remote viewer process using an IPC
 // channel of the given name.
 const char kViewerConnection[]              = "viewer-connection";
 
 // Cycle through a series of URLs listed in the specified file.
 const char kVisitURLs[]                     = "visit-urls";
 
+// Secure service url for Online Wallet Service

[Dan Beam, 2012/12/01 01:19:49]

nit: . at end of comments, s/url/URL/, also I think "online" is implied by it
being a service URL ;)

[ahutter, 2012/12/01 04:06:51]

Agreed, but Online Wallet is actually the name of the product.

+const char kWalletSecureServiceUrl[] = "wallet-secure-service-url";

[Dan Beam, 2012/11/30 19:55:52]

nit: line up = with = above (make some ASCII art)

[ahutter, 2012/12/01 04:06:51]

Done.

+
+// Service url for Online Wallet Service
+const char kWalletServiceUrl[] = "wallet-service-url";

[Dan Beam, 2012/12/01 01:19:49]

nit: are we ever talking to wallet *insecurely*? if so - why?!

[ahutter, 2012/12/01 04:06:51]

The secure url is used for escrowing credit card number and encrypting OTPs,
stuff we can't do on our regular servers.

+
 // Enable the "native services" feature of web-intents.
 const char kWebIntentsNativeServicesEnabled[] =
     "web-intents-native-services-enabled";
 
 // Enable invocation of web intents from web content.
 const char kWebIntentsInvocationEnabled[] =
     "enable-web-intents-invocation";
 
 // Adds the given extension ID to all the permission whitelists.
 const char kWhitelistedExtensionID[]        = "whitelisted-extension-id";
@@ skipping 270 matching lines @@
 #elif defined(OS_WIN)
   return CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kEnableChromeStyleDialogs);
 #else
   return CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kEnableChromeStyleDialogs);
 #endif
 }
 
 }  // namespace chrome