Fix slack tracking when instance prototype changes.

Fix slack tracking when instance prototype changes.

This fixes a corner case when the instance prototype of a function is
changed while inobject slack tracking is still in progress. This caused
the intial map to be unrelated for functions with the same shared info
and hence the shared construct stub is no longer generic enough to work
for all those functions.

R=danno@chromium.org
BUG=chromium:157019
TEST=mjsunit/regress/regress-crbug-157019

Committed: https://code.google.com/p/v8/source/detail?r=12896

[danno, 2012-11-07 17:26:47]

lgtm with comments

http://codereview.chromium.org/11293059/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/11293059/diff/1/src/objects.cc#newcode7735
src/objects.cc:7735: // First some logic for the map of the prototype to make
sure it is in
nit: unnecessary whitespace change

http://codereview.chromium.org/11293059/diff/1/src/objects.cc#newcode7742
src/objects.cc:7742: // Now some logic for the maps of the objects that are
created by
nit: unnecessary whitespace change

http://codereview.chromium.org/11293059/diff/1/src/objects.cc#newcode7746
src/objects.cc:7746: // copy containing the new prototype.  Also complete any
inobject
nit: "in object"

[Michael Starzinger, 2012-11-08 11:23:33]

Addressed comments. Landing.

https://chromiumcodereview.appspot.com/11293059/diff/1/src/objects.cc
File src/objects.cc (right):

https://chromiumcodereview.appspot.com/11293059/diff/1/src/objects.cc#newcode...
src/objects.cc:7735: // First some logic for the map of the prototype to make
sure it is in
On 2012/11/07 17:26:47, danno wrote:
> nit: unnecessary whitespace change

Done. My mental "break at 72 chars" algorithm kicked in. Sorry.

https://chromiumcodereview.appspot.com/11293059/diff/1/src/objects.cc#newcode...
src/objects.cc:7742: // Now some logic for the maps of the objects that are
created by
On 2012/11/07 17:26:47, danno wrote:
> nit: unnecessary whitespace change

Done. Likewise.

https://chromiumcodereview.appspot.com/11293059/diff/1/src/objects.cc#newcode...
src/objects.cc:7746: // copy containing the new prototype.  Also complete any
inobject
On 2012/11/07 17:26:47, danno wrote:
> nit: "in object"

Done. Used "in-object" as discussed offline.