Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: skia/ext/bitmap_platform_device_win.cc

Issue 11293036: Free the dibsection (HBITMAP) in PlatformBitmap's destructor, so we don't leak! (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | skia/ext/platform_canvas.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/ext/bitmap_platform_device_win.cc
===================================================================
--- skia/ext/bitmap_platform_device_win.cc (revision 165343)
+++ skia/ext/bitmap_platform_device_win.cc (working copy)
@@ -273,6 +273,10 @@
PlatformBitmap::~PlatformBitmap() {
if (surface_)
DeleteDC(surface_);
+
+ HBITMAP hbitmap = (HBITMAP)platform_extra_;
+ if (hbitmap)
+ DeleteObject(hbitmap);
}
bool PlatformBitmap::Allocate(int width, int height, bool is_opaque) {
@@ -287,6 +291,8 @@
// monochrome pixel wide and one monochrome pixel high. Since we select our
// own bitmap, we must delete the previous one.
DeleteObject(old_bitmap);
+ // remember the hbitmap, so we can free it in our destructor
+ platform_extra_ = (intptr_t)hbitmap;
return true;
}
« no previous file with comments | « no previous file | skia/ext/platform_canvas.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698