content/components/navigation_interception/DEPS - Issue 11293017: Move navigation interception component to content/components

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/components/navigation_interception/DEPS

Issue 11293017: Move navigation interception component to content/components (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/chrome_tests.gypi ('K') | « content/components/content_components.gyp ('k') | content/components/navigation_interception/OWNERS » ('j') | content/components/navigation_interception/intercept_navigation_resource_throttle.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+content/public",	2 "+content/public",

3 "+net/url_request",	3 "+net/url_request",

	4 "+navigation_interception/jni/InterceptNavigationDelegate_jni.h",
	Jói 2012/10/31 21:18:27 perhaps comment that this is a generated file? perhaps comment that this is a generated file? mkosiba (inactive) 2012/10/31 22:41:26 I always thought it is a BAD IDEA(tm) to generate I always thought it is a BAD IDEA(tm) to generate code to the source tree.. we have a system of generating the jni header to the out/ folder in place already, why do we need to depart from it in this case? John Knottenbelt 2012/11/02 14:48:25 The file is generated to the out/Debug/gen direc Show quoted text On 2012/10/31 22:41:26, Martin Kosiba wrote: > I always thought it is a BAD IDEA(tm) to generate code to the source tree.. we > have a system of generating the jni header to the out/ folder in place already, > why do we need to depart from it in this case? The file is generated to the out/Debug/gen directory. The gyp file adds that to the include path. I added this rule because otherwise checkdeps complains that no rule exists to allow the include. joth 2012/11/02 15:18:53 gotcha. I think the normal pattern it to just say Show quoted text On 2012/11/02 14:48:25, John Knottenbelt wrote: > On 2012/10/31 22:41:26, Martin Kosiba wrote: > > I always thought it is a BAD IDEA(tm) to generate code to the source tree.. we > > have a system of generating the jni header to the out/ folder in place > already, > > why do we need to depart from it in this case? > > The file is generated to the out/Debug/gen directory. The gyp file adds that > to the include path. I added this rule because otherwise checkdeps complains > that no rule exists to allow the include. gotcha. I think the normal pattern it to just say "+jni" in the DEPS. (see base/DEPS, content/DEPS etc) mkosiba (inactive) 2012/11/02 15:36:27 ah.. I see. Everyone else uses "+jni" Show quoted text On 2012/11/02 14:48:25, John Knottenbelt wrote: > On 2012/10/31 22:41:26, Martin Kosiba wrote: > > I always thought it is a BAD IDEA(tm) to generate code to the source tree.. we > > have a system of generating the jni header to the out/ folder in place > already, > > why do we need to depart from it in this case? > > The file is generated to the out/Debug/gen directory. The gyp file adds that > to the include path. I added this rule because otherwise checkdeps complains > that no rule exists to allow the include. ah.. I see. Everyone else uses "+jni"
	5 "+chrome/test/base/chrome_render_view_host_test_harness.h",

4 ]	6 ]

5	7

6 specific_include_rules = {	8 specific_include_rules = {

7 '.*_(a-z)+test\.cc': [	9 '.*_(a-z)+test\.cc': [

8 # Temporary until test case moves into a separate test runner.	10 # Temporary until test case moves into a separate test runner.

9 "!chrome/test/base",	11 "!chrome/test/base",

10 "+testing",	12 "+testing",

11 ],	13 ],

12 }	14 }

OLD	NEW