Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4129)

Unified Diff: chrome/browser/android/metrics/launch_metrics.cc

Issue 1129293009: Record whenever an app is launched from the Home screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/metrics/LaunchMetrics.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/metrics/launch_metrics.cc
diff --git a/chrome/browser/android/metrics/launch_metrics.cc b/chrome/browser/android/metrics/launch_metrics.cc
index 48dcdaaac74f1dccf1bf8bf17f49e8ef5954bd04..5ae5968581829ab43e52fd172340441eccb6a70f 100644
--- a/chrome/browser/android/metrics/launch_metrics.cc
+++ b/chrome/browser/android/metrics/launch_metrics.cc
@@ -7,8 +7,10 @@
#include "base/android/jni_string.h"
#include "base/metrics/histogram_macros.h"
#include "base/metrics/user_metrics.h"
+#include "chrome/browser/banners/app_banner_settings_helper.h"
#include "chrome/browser/browser_process.h"
#include "components/rappor/rappor_utils.h"
+#include "content/public/browser/web_contents.h"
#include "jni/LaunchMetrics_jni.h"
#include "url/gurl.h"
@@ -25,7 +27,21 @@ bool RegisterLaunchMetrics(JNIEnv* env) {
}
static void RecordLaunch(JNIEnv* env, jclass caller, jboolean standalone,
- jstring jurl) {
+ jstring jurl, jobject jweb_contents) {
+ GURL url(base::android::ConvertJavaStringToUTF8(env, jurl));
+
+ content::WebContents* web_contents =
+ content::WebContents::FromJavaWebContents(jweb_contents);
+ if (web_contents) {
+ // What a user has installed on the Home screen can become disconnected from
+ // what Chrome believes is on the Home screen if the user clears their data.
+ // Use the launch as a signal that the shortcut still exists.
+ AppBannerSettingsHelper::RecordBannerEvent(
+ web_contents, url, url.spec(),
+ AppBannerSettingsHelper::APP_BANNER_EVENT_DID_ADD_TO_HOMESCREEN,
+ base::Time::Now());
+ }
+
int action = standalone ? HOME_SCREEN_LAUNCH_STANDALONE
: HOME_SCREEN_LAUNCH_SHORTCUT;
std::string rappor_metric = standalone ? "Launch.HomeScreen.Standalone"
@@ -34,9 +50,8 @@ static void RecordLaunch(JNIEnv* env, jclass caller, jboolean standalone,
UMA_HISTOGRAM_ENUMERATION("Launch.HomeScreen", action,
HOME_SCREEN_LAUNCH_COUNT);
- std::string url = base::android::ConvertJavaStringToUTF8(env, jurl);
rappor::SampleDomainAndRegistryFromGURL(g_browser_process->rappor_service(),
- rappor_metric, GURL(url));
+ rappor_metric, url);
}
}; // namespace metrics
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/metrics/LaunchMetrics.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698