Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1129293007: Remove the obsolete HasPermission switch (Closed)

Created:
5 years, 7 months ago by Miguel Garcia
Modified:
5 years, 7 months ago
CC:
chromium-reviews, creis+watch_chromium.org, johnme+watch_chromium.org, nasko+codewatch_chromium.org, jam, mvanouwerkerk+watch_chromium.org, darin-cc_chromium.org, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the obsolete HasPermission switch BUG=479246 Committed: https://crrev.com/547154b809f5d920503832f661d02c627df2303d Cr-Commit-Position: refs/heads/master@{#330059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M chrome/browser/push_messaging/push_messaging_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/runtime_features.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Miguel Garcia
5 years, 7 months ago (2015-05-14 17:48:36 UTC) #2
Peter Beverloo
+0! \o/ lgtm
5 years, 7 months ago (2015-05-14 17:50:19 UTC) #3
Miguel Garcia
:) Love this +0 CLs :) Adding avi for content owners.
5 years, 7 months ago (2015-05-14 17:52:39 UTC) #5
Miguel Garcia
In the interest of time and assuming the change looks good can you click the ...
5 years, 7 months ago (2015-05-14 19:03:47 UTC) #6
Avi (use Gerrit)
lgtm
5 years, 7 months ago (2015-05-14 19:11:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129293007/1
5 years, 7 months ago (2015-05-15 07:05:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 07:49:38 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 07:50:25 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/547154b809f5d920503832f661d02c627df2303d
Cr-Commit-Position: refs/heads/master@{#330059}

Powered by Google App Engine
This is Rietveld 408576698