Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1129293005: Temporarily revert just Multiply to see if that's the source of NEON diffs. (Closed)

Created:
5 years, 7 months ago by mtklein_C
Modified:
5 years, 7 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Temporarily revert just Multiply to see if that's the source of NEON diffs. Local testing is confusing and inconclusive. Pulling out the big guns. BUG=skia: Committed: https://skia.googlesource.com/skia/+/5b9f352ff1e245dd48e200f8f8b683f4569547d3 Committed: https://skia.googlesource.com/skia/+/6095260e55ac5f263df26cdde427531a0e7da8dd

Patch Set 1 #

Patch Set 2 : try xor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/core/SkXfermode.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
mtklein
lgtm
5 years, 7 months ago (2015-05-14 16:08:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129293005/1
5 years, 7 months ago (2015-05-14 16:08:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/5b9f352ff1e245dd48e200f8f8b683f4569547d3
5 years, 7 months ago (2015-05-14 16:17:15 UTC) #5
mtklein
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1143553004/ by mtklein@google.com. ...
5 years, 7 months ago (2015-05-14 17:17:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129293005/20001
5 years, 7 months ago (2015-05-14 17:21:08 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/6095260e55ac5f263df26cdde427531a0e7da8dd
5 years, 7 months ago (2015-05-14 17:35:41 UTC) #10
mtklein
5 years, 7 months ago (2015-05-14 18:48:33 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1138073005/ by mtklein@google.com.

The reason for reverting is: Undo Xor revert.  Getting too confusing now..

Powered by Google App Engine
This is Rietveld 408576698