Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1129293004: Move token handle obtaining to UserSessionManager (Closed)

Created:
5 years, 7 months ago by Denis Kuznetsov (DE-MUC)
Modified:
5 years, 7 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move token handle obtaining to UserSessionManager BUG=484690, 484734 R=nkostylev@chromium.org Committed: https://crrev.com/71ede7fdaf6404ec0f70a60d60f679fee07902a9 Cr-Commit-Position: refs/heads/master@{#329868} Committed: https://crrev.com/d116d1094079601c3adefc30a597f95690635ecb Cr-Commit-Position: refs/heads/master@{#330110}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use bot to check if this fixes issue #

Patch Set 3 : . #

Total comments: 1

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -40 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.h View 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 chunk +1 line, -31 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.h View 1 5 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
Denis Kuznetsov (DE-MUC)
5 years, 7 months ago (2015-05-14 14:56:09 UTC) #1
Nikita (slow)
lgtm although TH backfill has to be multi-profiles safe as users may sign in while ...
5 years, 7 months ago (2015-05-14 16:27:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129293004/1
5 years, 7 months ago (2015-05-14 16:49:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 17:26:57 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/71ede7fdaf6404ec0f70a60d60f679fee07902a9 Cr-Commit-Position: refs/heads/master@{#329868}
5 years, 7 months ago (2015-05-14 17:27:49 UTC) #6
Evan Stade
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1140823007/ by estade@chromium.org. ...
5 years, 7 months ago (2015-05-14 19:00:49 UTC) #7
Nikita (slow)
https://codereview.chromium.org/1129293004/diff/1/chrome/browser/chromeos/login/session/user_session_manager.cc File chrome/browser/chromeos/login/session/user_session_manager.cc (right): https://codereview.chromium.org/1129293004/diff/1/chrome/browser/chromeos/login/session/user_session_manager.cc#newcode1678 chrome/browser/chromeos/login/session/user_session_manager.cc:1678: token_handle_util_.reset( I think you need to make sure that ...
5 years, 7 months ago (2015-05-15 04:05:08 UTC) #8
Nikita (slow)
https://codereview.chromium.org/1129293004/diff/60001/chrome/browser/chromeos/chrome_browser_main_chromeos.cc File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right): https://codereview.chromium.org/1129293004/diff/60001/chrome/browser/chromeos/chrome_browser_main_chromeos.cc#newcode726 chrome/browser/chromeos/chrome_browser_main_chromeos.cc:726: // Make sure that there is no pending URLRequests. ...
5 years, 7 months ago (2015-05-15 16:14:22 UTC) #10
Nikita (slow)
lgtm
5 years, 7 months ago (2015-05-15 16:17:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129293004/80001
5 years, 7 months ago (2015-05-15 16:23:19 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 7 months ago (2015-05-15 16:55:41 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 16:56:46 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d116d1094079601c3adefc30a597f95690635ecb
Cr-Commit-Position: refs/heads/master@{#330110}

Powered by Google App Engine
This is Rietveld 408576698