Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: build/config/BUILD.gn

Issue 1129293003: Sync defines with the GYP build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/allocator.gni") 5 import("//build/config/allocator.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/crypto.gni") 7 import("//build/config/crypto.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/ui.gni") 9 import("//build/config/ui.gni")
10 import("//build/module_args/v8.gni") 10 import("//build/module_args/v8.gni")
(...skipping 24 matching lines...) Expand all
35 35
36 # TODO(brettw) Most of these should be removed. Instead of global feature 36 # TODO(brettw) Most of these should be removed. Instead of global feature
37 # flags, we should have more modular flags that apply only to a target and its 37 # flags, we should have more modular flags that apply only to a target and its
38 # dependents. For example, depending on the "x11" meta-target should define 38 # dependents. For example, depending on the "x11" meta-target should define
39 # USE_X11 for all dependents so that everything that could use X11 gets the 39 # USE_X11 for all dependents so that everything that could use X11 gets the
40 # define, but anything that doesn't depend on X11 doesn't see it. 40 # define, but anything that doesn't depend on X11 doesn't see it.
41 # 41 #
42 # For now we define these globally to match the current GYP build. 42 # For now we define these globally to match the current GYP build.
43 config("feature_flags") { 43 config("feature_flags") {
44 # TODO(brettw) this probably needs to be parameterized. 44 # TODO(brettw) this probably needs to be parameterized.
45 defines = [ 45 defines = [ "V8_DEPRECATION_WARNINGS" ] # Don't use deprecated V8 APIs anywhe re.
46 "V8_DEPRECATION_WARNINGS", # Don't use deprecated V8 APIs anywhere.
47 ]
48 46
49 if (cld_version > 0) { 47 if (cld_version > 0) {
50 defines += [ "CLD_VERSION=$cld_version" ] 48 defines += [ "CLD_VERSION=$cld_version" ]
51 } 49 }
52 if (enable_mdns) { 50 if (enable_mdns) {
53 defines += [ "ENABLE_MDNS=1" ] 51 defines += [ "ENABLE_MDNS=1" ]
54 } 52 }
55 if (enable_notifications) { 53 if (enable_notifications) {
56 defines += [ "ENABLE_NOTIFICATIONS" ] 54 defines += [ "ENABLE_NOTIFICATIONS" ]
57 } 55 }
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 !disable_iterator_debugging) { 269 !disable_iterator_debugging) {
272 # Enable libstdc++ debugging facilities to help catch problems early, see 270 # Enable libstdc++ debugging facilities to help catch problems early, see
273 # http://crbug.com/65151 . 271 # http://crbug.com/65151 .
274 # TODO(phajdan.jr): Should we enable this for all of POSIX? 272 # TODO(phajdan.jr): Should we enable this for all of POSIX?
275 defines += [ "_GLIBCXX_DEBUG=1" ] 273 defines += [ "_GLIBCXX_DEBUG=1" ]
276 } 274 }
277 } 275 }
278 276
279 config("release") { 277 config("release") {
280 defines = [ "NDEBUG" ] 278 defines = [ "NDEBUG" ]
279
280 # Sanitizers.
281 # TODO(GYP) The GYP build has "release_valgrind_build == 0" for this
282 # condition. When Valgrind is set up, we need to do the same here.
283 if (!is_tsan) {
284 defines += [ "NVALGRIND" ]
285 if (!is_nacl) {
286 # NaCl always enables dynamic annotations. Currently this value is set to
287 # 1 for all .nexes.
288 defines += [ "DYNAMIC_ANNOTATIONS_ENABLED=0" ]
289 }
290 }
281 } 291 }
282 292
283 # Default libraries ------------------------------------------------------------ 293 # Default libraries ------------------------------------------------------------
284 294
285 # This config defines the default libraries applied to all targets. 295 # This config defines the default libraries applied to all targets.
286 config("default_libs") { 296 config("default_libs") {
287 if (is_win) { 297 if (is_win) {
288 # TODO(brettw) this list of defaults should probably be smaller, and 298 # TODO(brettw) this list of defaults should probably be smaller, and
289 # instead the targets that use the less common ones (e.g. wininet or 299 # instead the targets that use the less common ones (e.g. wininet or
290 # winspool) should include those explicitly. 300 # winspool) should include those explicitly.
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 "CoreFoundation.framework", 356 "CoreFoundation.framework",
347 "CoreGraphics.framework", 357 "CoreGraphics.framework",
348 "CoreText.framework", 358 "CoreText.framework",
349 "Foundation.framework", 359 "Foundation.framework",
350 "UIKit.framework", 360 "UIKit.framework",
351 ] 361 ]
352 } else if (is_linux) { 362 } else if (is_linux) {
353 libs = [ "dl" ] 363 libs = [ "dl" ]
354 } 364 }
355 } 365 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698