Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1129293003: Sync defines with the GYP build. (Closed)

Created:
5 years, 7 months ago by brettw
Modified:
5 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, jam, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync defines with the GYP build. BUG= Committed: https://crrev.com/9f7a2cb43a231998f6aaedf7e808562e9a46caaf Cr-Commit-Position: refs/heads/master@{#329357}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -6 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M build/config/BUILD.gn View 1 2 2 chunks +13 lines, -3 lines 0 comments Download
M build/config/compiler/BUILD.gn View 2 chunks +13 lines, -0 lines 0 comments Download
M build/config/features.gni View 1 chunk +5 lines, -1 line 0 comments Download
M components/autofill/content/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/autofill/core/browser/BUILD.gn View 2 chunks +15 lines, -1 line 0 comments Download
M third_party/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (9 generated)
brettw
5 years, 7 months ago (2015-05-12 00:04:33 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129293003/20001
5 years, 7 months ago (2015-05-12 00:09:19 UTC) #4
Dirk Pranke
lgtm assuming you fill in a more informative CL description. https://codereview.chromium.org/1129293003/diff/20001/build/config/BUILD.gn File build/config/BUILD.gn (right): https://codereview.chromium.org/1129293003/diff/20001/build/config/BUILD.gn#newcode243 ...
5 years, 7 months ago (2015-05-12 00:09:41 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-12 02:11:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129293003/20001
5 years, 7 months ago (2015-05-12 02:20:05 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/62899)
5 years, 7 months ago (2015-05-12 02:27:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129293003/20001
5 years, 7 months ago (2015-05-12 03:58:07 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/62916)
5 years, 7 months ago (2015-05-12 04:10:32 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129293003/40001
5 years, 7 months ago (2015-05-12 04:25:11 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-12 05:36:37 UTC) #19
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 05:38:26 UTC) #20
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/9f7a2cb43a231998f6aaedf7e808562e9a46caaf
Cr-Commit-Position: refs/heads/master@{#329357}

Powered by Google App Engine
This is Rietveld 408576698