Fix the System Profile with extensions.

chrome/browser/ui/browser_command_controller.cc

Index: chrome/browser/ui/browser_command_controller.cc
diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc
index 570de3e90725c3d34d091445a5d418eab49342d7..72e7c30f48a6ae30ac7fa53810f4d636829e2baf 100644
--- a/chrome/browser/ui/browser_command_controller.cc
+++ b/chrome/browser/ui/browser_command_controller.cc
@@ -954,7 +954,8 @@ void BrowserCommandController::InitCommandState() {
   command_updater_.UpdateCommandEnabled(IDC_ZOOM_MINUS, true);
 
   // Show various bits of UI
-  const bool guest_session = profile()->IsGuestSession();
+  const bool guest_session = profile()->IsGuestSession() ||
+                             profile()->IsSystemProfile();

[msw, 2015/05/21 04:34:43]

Should this code instead [D]CHECK against this if no browser instances should be
created for the system profile? (BrowserCommandController instances are only
created for Browser instances)

[Mike Lerman, 2015/05/21 15:27:31]

What happens on Mac (or Linux I think) when there's still a Menu even if there's
no Browser, such as if I Close the last browser or have User Manager open?

[msw, 2015/05/21 17:48:12]

I'm not entirely sure. Outside tests, it looks like the only instantiation is in
Browser, but I see that chrome/browser/app_controller_mac.mm uses its
CommandUpdater, |menuState_| in some static BrowserCommandController functions.
Maybe treat this like your Browser instance DCHECKs against using the system
profile for now?

[Mike Lerman, 2015/05/21 19:24:33]

DCHECK added.

   const bool normal_window = browser_->is_type_tabbed();
   UpdateOpenFileState(&command_updater_);
   command_updater_.UpdateCommandEnabled(IDC_CREATE_SHORTCUTS, false);
@@ -1193,6 +1194,7 @@ void BrowserCommandController::UpdateCommandsForBookmarkBar() {
   command_updater_.UpdateCommandEnabled(
       IDC_SHOW_BOOKMARK_BAR,
       browser_defaults::bookmarks_enabled && !profile()->IsGuestSession() &&
+          !profile()->IsGuestSession() &&

[msw, 2015/05/21 04:34:43]

ditto

[Mike Lerman, 2015/05/21 15:27:31]

changed to system

           !profile()->GetPrefs()->IsManagedPreference(
               bookmarks::prefs::kShowBookmarkBar) &&
           IsShowingMainUI());