Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1129283003: Make SkAdvancedTypefaceMetrics private. (Closed)

Created:
5 years, 7 months ago by reed1
Modified:
5 years, 7 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make SkAdvancedTypefaceMetrics private. Committed: https://skia.googlesource.com/skia/+/39a9a5069b25aa8b9529118cfd0ece5f412fb56b

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -218 lines) Patch
M gyp/core.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
D include/core/SkAdvancedTypefaceMetrics.h View 1 chunk +0 lines, -162 lines 0 comments Download
M include/core/SkTypeface.h View 4 chunks +14 lines, -3 lines 0 comments Download
A + src/core/SkAdvancedTypefaceMetrics.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/core/SkTypeface.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/fonts/SkGScalerContext.h View 1 chunk +1 line, -1 line 0 comments Download
M src/fonts/SkGScalerContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/fonts/SkTestScalerContext.h View 1 chunk +1 line, -1 line 0 comments Download
M src/fonts/SkTestScalerContext.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/pdf/SkPDFFont.cpp View 2 chunks +10 lines, -10 lines 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 1 4 chunks +6 lines, -6 lines 0 comments Download
M src/ports/SkFontHost_FreeType_common.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/ports/SkFontHost_mac.cpp View 5 chunks +5 lines, -4 lines 0 comments Download
M src/ports/SkFontHost_win.cpp View 1 2 5 chunks +5 lines, -7 lines 0 comments Download
M src/ports/SkTypeface_win_dw.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/ports/SkTypeface_win_dw.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
reed1
ptal
5 years, 7 months ago (2015-05-07 21:58:11 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129283003/1
5 years, 7 months ago (2015-05-07 21:58:29 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/763) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on ...
5 years, 7 months ago (2015-05-07 22:00:15 UTC) #6
bungeman-skia
On 2015/05/07 22:00:15, I haz the power (commit-bot) wrote: > Dry run: Try jobs failed ...
5 years, 7 months ago (2015-05-07 22:05:16 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129283003/20001
5 years, 7 months ago (2015-05-12 14:10:50 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/995) Build-Win-MSVC-x86_64-Debug-Trybot on ...
5 years, 7 months ago (2015-05-12 14:14:23 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129283003/40001
5 years, 7 months ago (2015-05-12 16:42:11 UTC) #13
reed1
ptal
5 years, 7 months ago (2015-05-12 16:46:03 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-12 16:48:27 UTC) #16
bungeman-skia
lgtm
5 years, 7 months ago (2015-05-12 16:49:24 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129283003/40001
5 years, 7 months ago (2015-05-12 16:49:36 UTC) #19
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 16:50:09 UTC) #20
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/39a9a5069b25aa8b9529118cfd0ece5f412fb56b

Powered by Google App Engine
This is Rietveld 408576698