Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: src/IceTargetLoweringARM32.cpp

Issue 1129263005: Convert Constant->emit() definitions to allow multiple targets to define them. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: replace with unimplemented as a reminder Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceTargetLoweringARM32.cpp
diff --git a/src/IceTargetLoweringARM32.cpp b/src/IceTargetLoweringARM32.cpp
index 287e42dab33537604c52d985b2e65abfc1aaf544..5e4b6b4476e2da1a2cb4bd60c2a139512c663af1 100644
--- a/src/IceTargetLoweringARM32.cpp
+++ b/src/IceTargetLoweringARM32.cpp
@@ -702,15 +702,28 @@ void TargetARM32::makeRandomRegisterPermutation(
UnimplementedError(Func->getContext()->getFlags());
}
-/* TODO(jvoung): avoid duplicate symbols with multiple targets.
-void ConstantUndef::emitWithoutDollar(GlobalContext *) const {
- llvm_unreachable("Not expecting to emitWithoutDollar undef");
+void TargetARM32::emit(const ConstantInteger32 *C) const {
+ if (!ALLOW_DUMP)
+ return;
+ Ostream &Str = Ctx->getStrEmit();
+ Str << getConstantPrefix() << C->getValue();
+}
+
+void TargetARM32::emit(const ConstantInteger64 *) const {
+ llvm_unreachable("Not expecting to emit 64-bit integers");
+}
+
+void TargetARM32::emit(const ConstantFloat *C) const {
+ UnimplementedError(Ctx->getFlags());
+}
+
+void TargetARM32::emit(const ConstantDouble *C) const {
+ UnimplementedError(Ctx->getFlags());
}
-void ConstantUndef::emit(GlobalContext *) const {
+void TargetARM32::emit(const ConstantUndef *) const {
llvm_unreachable("undef value encountered by emitter.");
}
-*/
TargetDataARM32::TargetDataARM32(GlobalContext *Ctx)
: TargetDataLowering(Ctx) {}

Powered by Google App Engine
This is Rietveld 408576698