Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: src/IceTargetLoweringX8632.h

Issue 1129263005: Convert Constant->emit() definitions to allow multiple targets to define them. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: report fatal Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceTargetLoweringARM32.cpp ('k') | src/IceTargetLoweringX8632.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTargetLoweringX8632.h
diff --git a/src/IceTargetLoweringX8632.h b/src/IceTargetLoweringX8632.h
index 8a3c36ecaa29c5e53a0ad21024fbde8fe464b43a..f114dba2fbdb9abedd171557f7fe6184a043cb5e 100644
--- a/src/IceTargetLoweringX8632.h
+++ b/src/IceTargetLoweringX8632.h
@@ -54,6 +54,14 @@ public:
return (typeWidthInBytes(Ty) + 3) & ~3;
}
void emitVariable(const Variable *Var) const override;
+
+ const char *getConstantPrefix() const final { return "$"; }
+ void emit(const ConstantUndef *C) const final;
+ void emit(const ConstantInteger32 *C) const final;
+ void emit(const ConstantInteger64 *C) const final;
+ void emit(const ConstantFloat *C) const final;
+ void emit(const ConstantDouble *C) const final;
+
void lowerArguments() override;
void addProlog(CfgNode *Node) override;
void addEpilog(CfgNode *Node) override;
@@ -523,11 +531,6 @@ private:
template <typename T> static void emitConstantPool(GlobalContext *Ctx);
};
-template <> void ConstantInteger32::emit(GlobalContext *Ctx) const;
-template <> void ConstantInteger64::emit(GlobalContext *Ctx) const;
-template <> void ConstantFloat::emit(GlobalContext *Ctx) const;
-template <> void ConstantDouble::emit(GlobalContext *Ctx) const;
-
} // end of namespace Ice
#endif // SUBZERO_SRC_ICETARGETLOWERINGX8632_H
« no previous file with comments | « src/IceTargetLoweringARM32.cpp ('k') | src/IceTargetLoweringX8632.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698