Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 1129233006: Fixes possible crash in TableView (Closed)

Created:
5 years, 7 months ago by sky
Modified:
5 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes possible crash in TableView The sequence leading to the crash is: . Enable sorting. . Have more than one selected row. . Remove one of the selected rows. The removed row must also contain the anchor. . Focus the table. The crash happened because we tried to get the view index for -1. In general the anchor shouldn't be -1 if there is at least one item in the selection. The only place anchor could be -1 and there is a selection is during removal. This patch fixes that. BUG=480296 TEST=covered by test now. R=sadrul@chromium.org Committed: https://crrev.com/def5587881b9878e1b8bb6491db2fc977a7e76f3 Cr-Commit-Position: refs/heads/master@{#329853}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M ui/views/controls/table/table_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/controls/table/table_view_unittest.cc View 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sky
5 years, 7 months ago (2015-05-13 20:04:30 UTC) #1
sadrul
lgtm
5 years, 7 months ago (2015-05-14 07:59:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129233006/1
5 years, 7 months ago (2015-05-14 15:07:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 15:11:01 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 15:11:54 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/def5587881b9878e1b8bb6491db2fc977a7e76f3
Cr-Commit-Position: refs/heads/master@{#329853}

Powered by Google App Engine
This is Rietveld 408576698