Fix direct load from APK on Samsung devices

Fix direct load from APK on Samsung devices

This patch re-enables loading from APK on Samsung devices where the mmap
exec check is skipped (due to
https://code.google.com/p/chromium/issues/detail?id=448084).

BUG=489267
Committed: https://crrev.com/7aead31bcd04864257308a5ce4509422d8fe83db
Cr-Commit-Position: refs/heads/master@{#330371}

[petrcermak, 2015-05-18 15:04:34]

petrcermak@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[petrcermak, 2015-05-18 15:04:35]

Hi, please review this small patch.

Thanks,
Petr

[rmcilroy, 2015-05-18 15:11:49]

lgtm for minimal change (cherry-picking), but as discussed below let's remove
all this probing code now.

https://codereview.chromium.org/1129223007/diff/1/base/android/java/src/org/c...
File base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java
(right):

https://codereview.chromium.org/1129223007/diff/1/base/android/java/src/org/c...
base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java:258:
mMapApkWithExecPermission = true;
I was just chatting with Andrew about this.  Let's just remove all the
ProbeMapApkWithExec code from the linker now. We were only doing this to decide
when we could start load-from-apk on 32bit devices and now we have just decided
we are going to do this for only L+, so we don't really need the UMA for this
any longer.

Saying that, we should cherry-pick this change into m43 and m44 so let's land
this as-is and cherry pick it then do the bigger change after, WDYT?

[petrcermak, 2015-05-18 15:14:00]

https://codereview.chromium.org/1129223007/diff/1/base/android/java/src/org/c...
File base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java
(right):

https://codereview.chromium.org/1129223007/diff/1/base/android/java/src/org/c...
base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java:258:
mMapApkWithExecPermission = true;
On 2015/05/18 15:11:48, rmcilroy wrote:
> I was just chatting with Andrew about this.  Let's just remove all the
> ProbeMapApkWithExec code from the linker now. We were only doing this to
decide
> when we could start load-from-apk on 32bit devices and now we have just
decided
> we are going to do this for only L+, so we don't really need the UMA for this
> any longer.
> 
> Saying that, we should cherry-pick this change into m43 and m44 so let's land
> this as-is and cherry pick it then do the bigger change after, WDYT?

Sounds good to me.

[petrcermak, 2015-05-18 15:14:06]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2015-05-18 15:14:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1129223007/1

[commit-bot: I haz the power, 2015-05-18 16:25:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-05-18 16:26:25]

Patchset 1 (id:??) landed as
https://crrev.com/7aead31bcd04864257308a5ce4509422d8fe83db
Cr-Commit-Position: refs/heads/master@{#330371}