Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 1129223005: Roll PDFium to 8f6445b. (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll PDFium to 8f6445b. This pulls in a new API that allows chrome to stop including private PDFium headers. Chrome is modified to use it, and the inculde rules are updated to reflect a "public header only" policy. BUG=486818 Committed: https://crrev.com/ce5a54c7151bcbe5accb108ed81554e4bde7280d Cr-Commit-Position: refs/heads/master@{#329487}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M pdf/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Tom Sepez
Lei, chromium side of change. Thanks.
5 years, 7 months ago (2015-05-12 19:52:27 UTC) #2
Lei Zhang
lgtm
5 years, 7 months ago (2015-05-12 20:28:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129223005/1
5 years, 7 months ago (2015-05-12 20:49:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 21:07:17 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 21:09:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce5a54c7151bcbe5accb108ed81554e4bde7280d
Cr-Commit-Position: refs/heads/master@{#329487}

Powered by Google App Engine
This is Rietveld 408576698