Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1129213002: Reintroduce ScriptedSpeech runtime switch (Closed)

Created:
5 years, 7 months ago by timvolodine
Modified:
5 years, 7 months ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Reintroduce ScriptedSpeech runtime switch We need to be able to control whether the speech recognition and speech synthesis APIs are exposed in JavaScript. They will not be exposed in WebView because they are currently not supported there. BUG=483889 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195262

Patch Set 1 #

Patch Set 2 : also add the switch to speech synthesis #

Total comments: 2

Patch Set 3 : rebase, add runtimeenabled annotation to event and utterance #

Patch Set 4 : restore ScriptedSpeech blink feature #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M Source/modules/speech/SpeechSynthesisEvent.idl View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.idl View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/speech/WindowSpeech.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/speech/WindowSpeechSynthesis.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
timvolodine
5 years, 7 months ago (2015-05-07 16:23:07 UTC) #2
Peter Beverloo
+mkwst for OWNERS lgtm
5 years, 7 months ago (2015-05-07 16:27:46 UTC) #4
Peter Beverloo
Comment on PS2: https://codereview.chromium.org/1129213002/diff/20001/Source/modules/speech/WindowSpeechSynthesis.idl File Source/modules/speech/WindowSpeechSynthesis.idl (right): https://codereview.chromium.org/1129213002/diff/20001/Source/modules/speech/WindowSpeechSynthesis.idl#newcode28 Source/modules/speech/WindowSpeechSynthesis.idl:28: RuntimeEnabled=ScriptedSpeech, We should also guard SpeechSynthesisEvent ...
5 years, 7 months ago (2015-05-08 11:25:56 UTC) #5
Mike West
lgtm
5 years, 7 months ago (2015-05-08 16:47:28 UTC) #6
timvolodine
thanks! https://codereview.chromium.org/1129213002/diff/20001/Source/modules/speech/WindowSpeechSynthesis.idl File Source/modules/speech/WindowSpeechSynthesis.idl (right): https://codereview.chromium.org/1129213002/diff/20001/Source/modules/speech/WindowSpeechSynthesis.idl#newcode28 Source/modules/speech/WindowSpeechSynthesis.idl:28: RuntimeEnabled=ScriptedSpeech, On 2015/05/08 11:25:56, Peter Beverloo wrote: > ...
5 years, 7 months ago (2015-05-12 15:38:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129213002/60001
5 years, 7 months ago (2015-05-12 16:54:01 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 16:57:14 UTC) #11
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195262

Powered by Google App Engine
This is Rietveld 408576698