Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1129203005: Also report navigation policy for createView if requested (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
Mike West
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Also report navigation policy for createView if requested If a link has target=_blank we don't navigate to it, but create a new tab, and then navigate to it. To be able to write a layout test for the policy used to create the new tab, I need to dump it here too BUG=454222 R=mkwst@chromium.org Committed: https://crrev.com/cfb07325e71784d1825923f8fef79c9ca52e61d9 Cr-Commit-Position: refs/heads/master@{#330307}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/shell/renderer/test_runner/web_test_proxy.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-05-17 13:01:08 UTC) #1
Mike West
LGTM. Are there web-visible impacts of the policy? Like, won't `window.opener` be set in such ...
5 years, 7 months ago (2015-05-17 13:14:02 UTC) #2
jochen (gone - plz use gerrit)
unless it's something like ignore or download, no, it's not web-visible (also not visible in ...
5 years, 7 months ago (2015-05-17 13:15:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129203005/1
5 years, 7 months ago (2015-05-17 13:15:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-17 13:30:00 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:32:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cfb07325e71784d1825923f8fef79c9ca52e61d9
Cr-Commit-Position: refs/heads/master@{#330307}

Powered by Google App Engine
This is Rietveld 408576698