Skips disabled menu items when selection is changed

ui/views/controls/menu/menu_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/menu/menu_controller.h"
 
 #include "base/i18n/case_conversion.h"
 #include "base/i18n/rtl.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
@@ skipping 1867 matching lines @@
 int MenuController::MenuDepth(MenuItemView* item) {
   return item ? (MenuDepth(item->GetParentMenuItem()) + 1) : 0;
 }
 
 void MenuController::IncrementSelection(int delta) {
   MenuItemView* item = pending_state_.item;
   DCHECK(item);
   if (pending_state_.submenu_open && item->HasSubmenu() &&
       item->GetSubmenu()->IsShowing()) {
     // A menu is selected and open, but none of its children are selected,
-    // select the first menu item.
+    // select the first menu item that is visible and enabled.
     if (item->GetSubmenu()->GetMenuItemCount()) {
-      SetSelection(item->GetSubmenu()->GetMenuItemAt(0), SELECTION_DEFAULT);
+      MenuItemView* to_select = FindFirstSelectableMenuItem(item);
+      if (to_select)
+        SetSelection(to_select, SELECTION_DEFAULT);
       return;
     }
   }
 
   if (item->has_children()) {
     CustomButton* button = GetFirstHotTrackedView(item);
     if (button) {
       button->SetHotTracked(false);
       View* to_make_hot = GetNextFocusableView(item, button, delta == 1);
       CustomButton* button_hot = CustomButton::AsCustomButton(to_make_hot);
@@ skipping 26 matching lines @@
           CustomButton* button_hot = CustomButton::AsCustomButton(to_make_hot);
           if (button_hot)
             button_hot->SetHotTracked(true);
           break;
         }
       }
     }
   }
 }
 
+MenuItemView* MenuController::FindFirstSelectableMenuItem(
+    MenuItemView* parent) {
+  MenuItemView* child = parent->GetSubmenu()->GetMenuItemAt(0);
+  if (!child->visible() || !child->enabled())
+    child = FindNextSelectableMenuItem(parent, 0, 1);
+  return child;
+}
+
 MenuItemView* MenuController::FindNextSelectableMenuItem(MenuItemView* parent,
                                                          int index,
                                                          int delta) {
   int start_index = index;
   int parent_count = parent->GetSubmenu()->GetMenuItemCount();
   // Loop through the menu items skipping any invisible menus. The loop stops
-  // when we wrap or find a visible child.
+  // when we wrap or find a visible and enabled child.
   do {
     index = (index + delta + parent_count) % parent_count;
     if (index == start_index)
       return NULL;
     MenuItemView* child = parent->GetSubmenu()->GetMenuItemAt(index);
-    if (child->visible())
+    if (child->visible() && child->enabled())
       return child;
   } while (index != start_index);
   return NULL;
 }
 
 void MenuController::OpenSubmenuChangeSelectionIfCan() {
   MenuItemView* item = pending_state_.item;
-  if (item->HasSubmenu() && item->enabled()) {
-    if (item->GetSubmenu()->GetMenuItemCount() > 0) {
-      SetSelection(item->GetSubmenu()->GetMenuItemAt(0),
-                   SELECTION_UPDATE_IMMEDIATELY);
-    } else {
-      // No menu items, just show the sub-menu.
-      SetSelection(item, SELECTION_OPEN_SUBMENU | SELECTION_UPDATE_IMMEDIATELY);
-    }
+  if (!item->HasSubmenu() || !item->enabled())
+    return;
+  MenuItemView* to_select = NULL;
+  if (item->GetSubmenu()->GetMenuItemCount() > 0)
+    to_select = FindFirstSelectableMenuItem(item);
+  if (to_select) {
+    SetSelection(to_select, SELECTION_UPDATE_IMMEDIATELY);
+    return;
   }
+  // No menu items, just show the sub-menu.
+  SetSelection(item, SELECTION_OPEN_SUBMENU | SELECTION_UPDATE_IMMEDIATELY);
 }
 
 void MenuController::CloseSubmenu() {
   MenuItemView* item = state_.item;
   DCHECK(item);
   if (!item->GetParentMenuItem())
     return;
   if (item->HasSubmenu() && item->GetSubmenu()->IsShowing())
     SetSelection(item, SELECTION_UPDATE_IMMEDIATELY);
   else if (item->GetParentMenuItem()->GetParentMenuItem())
@@ skipping 352 matching lines @@
   }
 }
 
 gfx::Screen* MenuController::GetScreen() {
   Widget* root = owner_ ? owner_->GetTopLevelWidget() : NULL;
   return root ? gfx::Screen::GetScreenFor(root->GetNativeView())
               : gfx::Screen::GetNativeScreen();
 }
 
 }  // namespace views