Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 1129203002: Adding unit tests for limited subset of DefaultPathRenderer (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Adding unit tests for limited subset of DefaultPathRenderer BUG=skia: Committed: https://skia.googlesource.com/skia/+/622d3aded25f7ddf220634546cc3da12bf30d5a6

Patch Set 1 #

Patch Set 2 : tidy #

Total comments: 1

Patch Set 3 : more tidying #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M src/gpu/GrDefaultPathRenderer.cpp View 1 2 2 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
joshualitt
ptal
5 years, 7 months ago (2015-05-07 14:42:18 UTC) #2
robertphillips
lgtm + a question https://codereview.chromium.org/1129203002/diff/20001/src/gpu/GrDefaultPathRenderer.cpp File src/gpu/GrDefaultPathRenderer.cpp (right): https://codereview.chromium.org/1129203002/diff/20001/src/gpu/GrDefaultPathRenderer.cpp#newcode775 src/gpu/GrDefaultPathRenderer.cpp:775: Do we need to randomize ...
5 years, 7 months ago (2015-05-07 14:51:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129203002/40001
5 years, 7 months ago (2015-05-07 15:07:32 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 15:13:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/622d3aded25f7ddf220634546cc3da12bf30d5a6

Powered by Google App Engine
This is Rietveld 408576698